Don't record dependencies in SummaryDataStore.

pkg/analyzer/test/src/summary/package_bundle_reader_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analyzer/src/context/cache.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/summary/idl.dart';
 import 'package:analyzer/src/summary/package_bundle_reader.dart';
 import 'package:analyzer/src/task/dart.dart';
@@ skipping 135 matching lines @@
 
   test_compute_SOURCE_KIND_partSource() {
     bool success = provider.compute(entry2, SOURCE_KIND);
     expect(success, isTrue);
     expect(entry2.getValue(SOURCE_KIND), SourceKind.PART);
   }
 }
 
 @reflectiveTest
 class SummaryDataStoreTest {
-  SummaryDataStore dataStore = new SummaryDataStore(<String>[],
-      recordDependencyInfo: true, disallowOverlappingSummaries: true);
+  SummaryDataStore dataStore =
+      new SummaryDataStore(<String>[], disallowOverlappingSummaries: true);
 
   PackageBundle bundle1 = new _PackageBundleMock();
   PackageBundle bundle2 = new _PackageBundleMock();
   UnlinkedUnit unlinkedUnit11 = new _UnlinkedUnitMock();
   UnlinkedUnit unlinkedUnit12 = new _UnlinkedUnitMock();
   UnlinkedUnit unlinkedUnit21 = new _UnlinkedUnitMock();
   LinkedLibrary linkedLibrary1 = new _LinkedLibraryMock();
   LinkedLibrary linkedLibrary2 = new _LinkedLibraryMock();
 
   void setUp() {
     _setupDataStore(dataStore);
   }
 
   test_addBundle() {
     expect(dataStore.bundles, unorderedEquals([bundle1, bundle2]));
-    expect(dataStore.dependencies[0].summaryPath, '/p1.ds');
-    expect(dataStore.dependencies[0].apiSignature, 'signature1');
-    expect(dataStore.dependencies[0].includedPackageNames, ['p1']);
-    expect(dataStore.dependencies[0].includesFileUris, false);
-    expect(dataStore.dependencies[0].includesDartUris, false);
-    expect(dataStore.dependencies[1].summaryPath, '/p2.ds');
-    expect(dataStore.dependencies[1].apiSignature, 'signature2');
-    expect(dataStore.dependencies[1].includedPackageNames, ['p2']);
-    expect(dataStore.dependencies[1].includesFileUris, false);
-    expect(dataStore.dependencies[1].includesDartUris, false);
     expect(dataStore.uriToSummaryPath,
         containsPair('package:p1/u1.dart', '/p1.ds'));
     // unlinkedMap
     expect(dataStore.unlinkedMap, hasLength(3));
     expect(dataStore.unlinkedMap,
         containsPair('package:p1/u1.dart', unlinkedUnit11));
     expect(dataStore.unlinkedMap,
         containsPair('package:p1/u2.dart', unlinkedUnit12));
     expect(dataStore.unlinkedMap,
         containsPair('package:p2/u1.dart', unlinkedUnit21));
     // linkedMap
     expect(dataStore.linkedMap, hasLength(2));
     expect(dataStore.linkedMap,
         containsPair('package:p1/u1.dart', linkedLibrary1));
     expect(dataStore.linkedMap,
         containsPair('package:p2/u1.dart', linkedLibrary2));
   }
 
   test_addBundle_dartUris() {
     PackageBundle bundle = new _PackageBundleMock();
     when(bundle.unlinkedUnitUris).thenReturn(<String>['dart:core']);
     when(bundle.unlinkedUnits).thenReturn(<UnlinkedUnit>[unlinkedUnit11]);
     when(bundle.linkedLibraryUris).thenReturn(<String>['dart:core']);
     when(bundle.linkedLibraries).thenReturn(<LinkedLibrary>[linkedLibrary1]);
     when(bundle.apiSignature).thenReturn('signature');
     dataStore.addBundle('/p3.ds', bundle);
-    expect(dataStore.dependencies.last.includedPackageNames, []);
-    expect(dataStore.dependencies.last.includesFileUris, false);
-    expect(dataStore.dependencies.last.includesDartUris, true);
   }
 
   test_addBundle_fileUris() {
     PackageBundle bundle = new _PackageBundleMock();
     when(bundle.unlinkedUnitUris).thenReturn(<String>['file:/foo.dart']);
     when(bundle.unlinkedUnits).thenReturn(<UnlinkedUnit>[unlinkedUnit11]);
     when(bundle.linkedLibraryUris).thenReturn(<String>['file:/foo.dart']);
     when(bundle.linkedLibraries).thenReturn(<LinkedLibrary>[linkedLibrary1]);
     when(bundle.apiSignature).thenReturn('signature');
     dataStore.addBundle('/p3.ds', bundle);
-    expect(dataStore.dependencies.last.includedPackageNames, []);
-    expect(dataStore.dependencies.last.includesFileUris, true);
-    expect(dataStore.dependencies.last.includesDartUris, false);
   }
 
   test_addBundle_multiProject() {
     PackageBundle bundle = new _PackageBundleMock();
     when(bundle.unlinkedUnitUris)
         .thenReturn(<String>['package:p2/u1.dart', 'package:p1/u1.dart']);
     when(bundle.unlinkedUnits)
         .thenReturn(<UnlinkedUnit>[unlinkedUnit21, unlinkedUnit11]);
     when(bundle.linkedLibraryUris)
         .thenReturn(<String>['package:p2/u1.dart', 'package:p1/u1.dart']);
     when(bundle.linkedLibraries)
         .thenReturn(<LinkedLibrary>[linkedLibrary2, linkedLibrary1]);
     when(bundle.apiSignature).thenReturn('signature');
     // p3 conflicts (overlaps) with existing summaries.
     expect(() => dataStore.addBundle('/p3.ds', bundle),
         throwsA(isConflictingSummaryException));
-    expect(dataStore.dependencies.last.includedPackageNames, ['p1', 'p2']);
   }
 
   test_addBundle_multiProjectOverlap() {
-    SummaryDataStore dataStore2 = new SummaryDataStore(<String>[],
-        recordDependencyInfo: true, disallowOverlappingSummaries: false);
+    SummaryDataStore dataStore2 =
+        new SummaryDataStore(<String>[], disallowOverlappingSummaries: false);
     _setupDataStore(dataStore2);
 
     PackageBundle bundle = new _PackageBundleMock();
     when(bundle.unlinkedUnitUris)
         .thenReturn(<String>['package:p2/u1.dart', 'package:p1/u1.dart']);
     when(bundle.unlinkedUnits)
         .thenReturn(<UnlinkedUnit>[unlinkedUnit21, unlinkedUnit11]);
     when(bundle.linkedLibraryUris)
         .thenReturn(<String>['package:p2/u1.dart', 'package:p1/u1.dart']);
     when(bundle.linkedLibraries)
         .thenReturn(<LinkedLibrary>[linkedLibrary2, linkedLibrary1]);
     when(bundle.apiSignature).thenReturn('signature');
     // p3 conflicts (overlaps) with existing summaries, but now allowed.
     dataStore2.addBundle('/p3.ds', bundle);
-    expect(dataStore2.dependencies.last.includedPackageNames, ['p1', 'p2']);
   }
 
   test_getContainingLibraryUris_libraryUri() {
     String partUri = 'package:p1/u1.dart';
     List<String> uris = dataStore.getContainingLibraryUris(partUri);
     expect(uris, unorderedEquals([partUri]));
   }
 
   test_getContainingLibraryUris_partUri() {
     String partUri = 'package:p1/u2.dart';
@@ skipping 74 matching lines @@
   @override
   bool hasResultsForSource(Source source) {
     return sourcesWithResults.contains(source);
   }
 }
 
 class _UnlinkedPublicNamespaceMock extends Mock
     implements UnlinkedPublicNamespace {}
 
 class _UnlinkedUnitMock extends Mock implements UnlinkedUnit {}