Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2996733002: Fix test broken by block 10. (Closed)

Created:
3 years, 4 months ago by jcollins
Modified:
3 years, 4 months ago
Reviewers:
bkonyi
CC:
dart2now-team_google.com, reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix test broken by block 10. Analyzer behavior is different when using --strong and --checked vs --strong alone. BUG= R=bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/06929f1ada88be26c052da6a1dfeef65355d44f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/corelib_2/corelib_2.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jcollins
3 years, 4 months ago (2017-08-09 16:35:11 UTC) #2
bkonyi
lgtm
3 years, 4 months ago (2017-08-09 16:35:52 UTC) #3
jcollins
3 years, 4 months ago (2017-08-09 16:36:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
06929f1ada88be26c052da6a1dfeef65355d44f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698