Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: pkg/compiler/lib/src/constants/expressions.dart

Issue 2996723002: Support typedef type literals (Closed)
Patch Set: Cleanup Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/constants/expressions.dart
diff --git a/pkg/compiler/lib/src/constants/expressions.dart b/pkg/compiler/lib/src/constants/expressions.dart
index 159488ab4364e7bb89b0f9374f5b1b93012736c6..88c054e44c7c6add4a8197df298fb83dd710892f 100644
--- a/pkg/compiler/lib/src/constants/expressions.dart
+++ b/pkg/compiler/lib/src/constants/expressions.dart
@@ -741,8 +741,10 @@ class TypeConstantExpression extends ConstantExpression {
assert(
type.isInterfaceType ||
type.isTypedef ||
- type.isFunctionType ||
- type.isDynamic,
+ type.isDynamic
+ // TODO(johnniwinther): Remove this when [KernelAstAdapter] is removed.
Siggi Cherem (dart-lang) 2017/08/09 16:38:06 which one do you intend to remove? isFunctionType?
Johnni Winther 2017/08/10 08:18:34 Done.
+ ||
+ type.isFunctionType,
"Unexpected type constant type: $type");
}
« no previous file with comments | « no previous file | pkg/compiler/lib/src/elements/entities.dart » ('j') | pkg/compiler/lib/src/elements/entities.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698