Support typedef type literals

Support typedef type literals

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/73d99c5645cdd7b4d3e903b90c144f993cc6361b

[Johnni Winther, 2017-08-09 15:33:47]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-08-09 16:38:07]

lgtm

I thought some language/corelib tests would also change status, nothing was
affected by this?

https://codereview.chromium.org/2996723002/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/constants/expressions.dart (right):

https://codereview.chromium.org/2996723002/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/expressions.dart:745: // TODO(johnniwinther):
Remove this when [KernelAstAdapter] is removed.
which one do you intend to remove? isFunctionType? if so, consider moving the ||
above this line.

https://codereview.chromium.org/2996723002/diff/20001/pkg/compiler/lib/src/el...
File pkg/compiler/lib/src/elements/entities.dart (right):

https://codereview.chromium.org/2996723002/diff/20001/pkg/compiler/lib/src/el...
pkg/compiler/lib/src/elements/entities.dart:55: /// The library in which the
library was declared.
=> in which the *typedef*

https://codereview.chromium.org/2996723002/diff/20001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2996723002/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/element_map_impl.dart:628: List<TypedefData> get
_typedefData;
given we have so many of these now, it might be worth adding a datatype that
helps keep the invariants straight. For example, something with this flavor:

class FastLookupMap<K extends IndexableItem, V> {
  List<K> keys;
  List<V> values;

  void operator []=(K key, V value) {
    var index = keys.length;
    assert (key.index == null);
    key.index = key;
    keys.add(key);
    values.add(value);
  }

  // or if we want to make the index final, then:
  void put(K createKey(int index), V createValue(K key)) {
    var index = keys.length;
    key = createKey(index);
    keys.add(key);
    values.add(createValue(key));
  }

  void operator [](K key) => values[key.index];
}

that would deal with the fact that list/data are the same length and are
consistently updated?

[Johnni Winther, 2017-08-10 08:18:28]

On 2017/08/09 16:38:07, Siggi Cherem (dart-lang) wrote:
> I thought some language/corelib tests would also change status, nothing was
> affected by this?
> 
It mainly changes the name of the generated constant, so it might not make new
stuff work. 

Haven't tested, though - I get different results when trying to test locally(!),
so I need the buildbot results, anyway.

[Johnni Winther, 2017-08-10 08:18:35]

https://codereview.chromium.org/2996723002/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/constants/expressions.dart (right):

https://codereview.chromium.org/2996723002/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/constants/expressions.dart:745: // TODO(johnniwinther):
Remove this when [KernelAstAdapter] is removed.
On 2017/08/09 16:38:06, Siggi Cherem (dart-lang) wrote:
> which one do you intend to remove? isFunctionType? if so, consider moving the
||
> above this line.

Done.

https://codereview.chromium.org/2996723002/diff/20001/pkg/compiler/lib/src/el...
File pkg/compiler/lib/src/elements/entities.dart (right):

https://codereview.chromium.org/2996723002/diff/20001/pkg/compiler/lib/src/el...
pkg/compiler/lib/src/elements/entities.dart:55: /// The library in which the
library was declared.
On 2017/08/09 16:38:06, Siggi Cherem (dart-lang) wrote:
> => in which the *typedef*

Done.

https://codereview.chromium.org/2996723002/diff/20001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2996723002/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/element_map_impl.dart:628: List<TypedefData> get
_typedefData;
On 2017/08/09 16:38:07, Siggi Cherem (dart-lang) wrote:
> given we have so many of these now, it might be worth adding a datatype that
> helps keep the invariants straight. For example, something with this flavor:
> 
> class FastLookupMap<K extends IndexableItem, V> {
>   List<K> keys;
>   List<V> values;
> 
>   void operator []=(K key, V value) {
>     var index = keys.length;
>     assert (key.index == null);
>     key.index = key;
>     keys.add(key);
>     values.add(value);
>   }
> 
>   // or if we want to make the index final, then:
>   void put(K createKey(int index), V createValue(K key)) {
>     var index = keys.length;
>     key = createKey(index);
>     keys.add(key);
>     values.add(createValue(key));
>   }
> 
>   void operator [](K key) => values[key.index];
> }
> 
> that would deal with the fact that list/data are the same length and are
> consistently updated?

Acknowledged. Will do in a follow-up.

[Johnni Winther, 2017-08-10 08:30:41]

Description was changed from

==========
Support typedef type literals
==========

to

==========
Support typedef type literals

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/73d99c5645cdd7b4d3e903b90c144f993cc6361b
==========

[Johnni Winther, 2017-08-10 08:30:43]

Committed patchset #3 (id:40001) manually as
73d99c5645cdd7b4d3e903b90c144f993cc6361b (presubmit successful).