Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2996703002: Test failing fix (Closed)

Created:
3 years, 4 months ago by maxkim
Modified:
3 years, 4 months ago
Reviewers:
regis, Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test failing fix. Stdin is mocked to avoid the typing issue; not critical for this unit test. BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/bd8d28dddd2b60ad92fbe1d8917a81c12ae350a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M pkg/analysis_server_client/test/analysis_server_client_test.dart View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
maxkim
3 years, 4 months ago (2017-08-08 23:07:55 UTC) #3
regis
I'm not familiar with this code to review, but I can approve as the gardener ...
3 years, 4 months ago (2017-08-09 00:32:32 UTC) #5
maxkim
On 2017/08/09 00:32:32, regis wrote: > I'm not familiar with this code to review, but ...
3 years, 4 months ago (2017-08-09 01:58:38 UTC) #6
maxkim
Committed patchset #1 (id:1) manually as bd8d28dddd2b60ad92fbe1d8917a81c12ae350a4 (presubmit successful).
3 years, 4 months ago (2017-08-09 02:00:45 UTC) #8
Brian Wilkerson
3 years, 4 months ago (2017-08-09 13:38:45 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698