translate missing ">" fasta error code to analyzer error

translate missing ">" fasta error code to analyzer error

Fix #30320

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/02ce5106012a447d431c7f2cb03d9307155bf8a2

[danrubel, 2017-08-08 19:35:48]

danrubel@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-08-08 20:45:22]

lgtm

https://codereview.chromium.org/2996673002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/scanner_test.dart (right):

https://codereview.chromium.org/2996673002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/scanner_test.dart:82: void test_issue_30320() {
I used to do this too, but now I think that it is better to name tests with
explicit information what it is testing. Bug id requires additional
manipulations to get this information ;-)

[ahe, 2017-08-09 07:04:41]

ahe@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-08-09 07:04:42]

DBC/FYI/food for thought :-)

https://codereview.chromium.org/2996673002/diff/1/pkg/front_end/lib/src/scann...
File pkg/front_end/lib/src/scanner/errors.dart (right):

https://codereview.chromium.org/2996673002/diff/1/pkg/front_end/lib/src/scann...
pkg/front_end/lib/src/scanner/errors.dart:132: if (errorCode ==
codeUnmatchedToken) {
Perhaps we should start thinking about how to simplify this translation by
adding more error codes to pkg/front_end/messages.yaml.

My hope for the analyzer error codes in messages.yaml is that all the cases in
"default" could move up and have their own "case".

Another thing we could do is generate an enum and use that instead of strings.

[danrubel, 2017-08-11 18:06:50]

https://codereview.chromium.org/2996673002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/scanner_test.dart (right):

https://codereview.chromium.org/2996673002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/scanner_test.dart:82: void test_issue_30320() {
On 2017/08/08 20:45:22, scheglov wrote:
> I used to do this too, but now I think that it is better to name tests with
> explicit information what it is testing. Bug id requires additional
> manipulations to get this information ;-)

Good point. Renamed.

https://codereview.chromium.org/2996673002/diff/1/pkg/front_end/lib/src/scann...
File pkg/front_end/lib/src/scanner/errors.dart (right):

https://codereview.chromium.org/2996673002/diff/1/pkg/front_end/lib/src/scann...
pkg/front_end/lib/src/scanner/errors.dart:132: if (errorCode ==
codeUnmatchedToken) {
On 2017/08/09 07:04:41, ahe wrote:
> Perhaps we should start thinking about how to simplify this translation by
> adding more error codes to pkg/front_end/messages.yaml.
> 
> My hope for the analyzer error codes in messages.yaml is that all the cases in
> "default" could move up and have their own "case".
> 
> Another thing we could do is generate an enum and use that instead of strings.

Good ideas. I will address these in a future CL.

[danrubel, 2017-08-11 19:29:55]

Description was changed from

==========
translate missing ">" fasta error code to analyzer error

Fix #30320
==========

to

==========
translate missing ">" fasta error code to analyzer error

Fix #30320

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/02ce5106012a447d431c7f2cb03d9307155bf8a2
==========

[danrubel, 2017-08-11 19:29:56]

Committed patchset #2 (id:20001) manually as
02ce5106012a447d431c7f2cb03d9307155bf8a2 (presubmit successful).