Issue 299663014: Suppress psabi warnings in GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 299663014: Suppress psabi warnings in GN build. (Closed)

Created:
6 years, 7 months ago by brettw

Modified:
6 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Suppress psabi warnings in GN build. These are disabled currently in the Android ARM GYP build. This patch disables it for all ARM builds since the warning appears when cross-compiling to ARM on Linux without Android (this isn't something people normally compile, so probably nobody noticed). R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271951

Patch Set 1 #

Patch Set 2 : grammar #

Total comments: 2

Patch Set 3 : comment #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	build/config/compiler/BUILD.gn	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm https://codereview.chromium.org/299663014/diff/20001/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/299663014/diff/20001/build/config/compiler/BUILD.gn#newcode606 build/config/compiler/BUILD.gn:606: # Suppress warnings about ABI changes on ARM ...

6 years, 7 months ago (2014-05-21 19:43:59 UTC) #2

brettw

Committed patchset #3 manually as r271951 (presubmit successful).

6 years, 7 months ago (2014-05-21 20:07:09 UTC) #3

brettw

6 years, 7 months ago (2014-05-21 20:07:32 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/299663014/diff/20001/build/config/compiler/BU...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/299663014/diff/20001/build/config/compiler/BU...
build/config/compiler/BUILD.gn:606: # Suppress warnings about ABI changes on ARM
(Clang doesn't support this).
I clarified this.

Expand Messages | Collapse Messages