Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 299663011: Introduce MetricsServiceClient::StartGatheringMetrics (Closed)

Created:
6 years, 7 months ago by blundell
Modified:
6 years, 7 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Introduce MetricsServiceClient::StartGatheringMetrics This API is called when initial metrics gathering should start, and takes in a callback that is called when initial metrics gathering is complete. It is currently empty but will be filled in as initial metrics gathering code moves out of MetricsService. BUG=374231 R=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272479

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M chrome/browser/metrics/chrome_metrics_service_client.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M components/metrics/metrics_service_client.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M components/metrics/test_metrics_service_client.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/metrics/test_metrics_service_client.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
blundell
6 years, 7 months ago (2014-05-21 11:33:26 UTC) #1
Alexei Svitkine (slow)
lgtm
6 years, 7 months ago (2014-05-21 12:32:25 UTC) #2
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 7 months ago (2014-05-22 15:10:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/299663011/1
6 years, 7 months ago (2014-05-22 15:10:50 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 15:35:23 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 15:42:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69217) ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/18117)
6 years, 7 months ago (2014-05-22 15:42:29 UTC) #7
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 7 months ago (2014-05-23 08:18:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/299663011/20001
6 years, 7 months ago (2014-05-23 08:19:32 UTC) #9
blundell
6 years, 7 months ago (2014-05-23 10:56:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r272479 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698