pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart - Issue 2996573002: fix #28988, remove throw on Dart1 incompatible is-checks for dartdevc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart

Issue 2996573002: fix #28988, remove throw on Dart1 incompatible is-checks for dartdevc (Closed)

Patch Set: fix changelog Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart

index ea935073b2c47092ab0848fdb6998d70e584662f..463b970dcfd21f7d24493fcb77ffafa7dcfa33de 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart

@@ -123,11 +123,8 @@ final global_ = JS(

settings.ignoreWhitelistedErrors : true);

$ignoreAllErrors(

- 'ignoreAllErrors' in settings ?settings.ignoreAllErrors : false);

+ 'ignoreAllErrors' in settings ? settings.ignoreAllErrors : false);

- $failForWeakModeIsChecks(

- 'failForWeakModeIsChecks' in settings ?

- settings.failForWeakModeIsChecks : true);

$trackProfile(

'trackProfile' in settings ? settings.trackProfile : false);