pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/generators.dart - Issue 2996573002: fix #28988, remove throw on Dart1 incompatible is-checks for dartdevc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/generators.dart

Issue 2996573002: fix #28988, remove throw on Dart1 incompatible is-checks for dartdevc (Closed)

Patch Set: fix changelog Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart ('k') | pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/generators.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/generators.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/generators.dart

index 99d3b3f27f2a21c5a4539f2b5767fc55be30a8dd..63c2e11c3f149a5628032f851c7f87795a2c339b 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/generators.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/generators.dart

@@ -62,7 +62,7 @@ async_(gen, T, @rest args) => JS(

let result = FutureT.microtask(function() {

iter = $gen.apply(null, $args)[Symbol.iterator]();

var result = onValue();

- if ($strongInstanceOf(result, FutureT) == null) {

+ if ($isSubtype($getReifiedType(result), FutureT) == null) {

// Chain the Future<dynamic> to a Future<T> to produce the correct

// final type.

return result.then($T)((x) => x, {onError: onError});