Chromium Code Reviews| Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart |
| diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart |
| index b2b982a19928b24dbdc69e76e0ae5a357ead6115..14f89cf55ef8da5fe9efde43a77272f1f50dbff0 100644 |
| --- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart |
| +++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart |
| @@ -21,25 +21,6 @@ void ignoreAllErrors(bool flag) { |
| JS('', 'dart.__ignoreAllErrors = #', flag); |
| } |
| -/// Throw an exception on `is` checks that would return an unsound answer in |
| -/// non-strong mode Dart. |
| -/// |
| -/// For example `x is List<int>` where `x = <Object>['hello']`. |
| -/// |
| -/// These checks behave correctly in strong mode (they return false), however, |
| -/// they will produce a different answer if run on a platform without strong |
| -/// mode. As a debugging feature, these checks can be configured to throw, to |
| -/// avoid seeing different behavior between modes. |
| -/// |
| -/// (There are many other ways that different `is` behavior can be observed, |
| -/// however, even with this flag. The most obvious is due to lack of reified |
| -/// generic type parameters. This affects generic functions and methods, as |
| -/// well as generic types when the type parameter was inferred. Setting this |
| -/// flag to `true` will not catch these differences in behavior..) |
| -void failForWeakModeIsChecks(bool flag) { |
| - JS('', 'dart.__failForWeakModeIsChecks = #', flag); |
|
Leaf
2017/08/05 02:24:27
Is it worth keeping this flag, just turned off? I
Jennifer Messerly
2017/08/07 23:30:53
yeah ... IMO, less code to keep around as we do al
|
| -} |
| - |
| throwCastError(object, actual, type) { |
| var found = typeName(actual); |
| var expected = typeName(type); |