Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: pkg/dev_compiler/test/browser/language_tests.js

Issue 2996573002: fix #28988, remove throw on Dart1 incompatible is-checks for dartdevc (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require', 5 define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require',
6 'test_status'], 6 'test_status'],
7 function(dart_sdk, async_helper, expect, unittest, is, require, 7 function(dart_sdk, async_helper, expect, unittest, is, require,
8 test_status) { 8 test_status) {
9 'use strict'; 9 'use strict';
10 10
11 async_helper = async_helper.async_helper; 11 async_helper = async_helper.async_helper;
12 let minitest = expect.minitest; 12 let minitest = expect.minitest;
13 let mochaOnError = window.onerror; 13 let mochaOnError = window.onerror;
14 dart_sdk.dart.trapRuntimeErrors(false); 14 dart_sdk.dart.trapRuntimeErrors(false);
15 dart_sdk.dart.ignoreWhitelistedErrors(false); 15 dart_sdk.dart.ignoreWhitelistedErrors(false);
16 dart_sdk.dart.failForWeakModeIsChecks(false);
17 dart_sdk._isolate_helper.startRootIsolate(function() {}, []); 16 dart_sdk._isolate_helper.startRootIsolate(function() {}, []);
18 // Make it easier to debug test failures and required for formatter test that 17 // Make it easier to debug test failures and required for formatter test that
19 // assumes custom formatters are enabled. 18 // assumes custom formatters are enabled.
20 dart_sdk._debugger.registerDevtoolsFormatter(); 19 dart_sdk._debugger.registerDevtoolsFormatter();
21 20
22 let html_config = unittest.html_config; 21 let html_config = unittest.html_config;
23 // Test attributes are a list of strings, or a string for a single 22 // Test attributes are a list of strings, or a string for a single
24 // attribute. Valid attributes are: 23 // attribute. Valid attributes are:
25 // 24 //
26 // 'pass' - test passes (default) 25 // 'pass' - test passes (default)
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 'async_star_test_03_multi': async_unittest, 74 'async_star_test_03_multi': async_unittest,
76 'async_star_test_04_multi': async_unittest, 75 'async_star_test_04_multi': async_unittest,
77 'async_star_test_05_multi': async_unittest, 76 'async_star_test_05_multi': async_unittest,
78 77
79 'async_switch_test': fail, 78 'async_switch_test': fail,
80 'asyncstar_throw_in_catch_test': ['skip', 'fail'], 79 'asyncstar_throw_in_catch_test': ['skip', 'fail'],
81 'await_future_test': skip_timeout, 80 'await_future_test': skip_timeout,
82 'await_for_test': 'slow', 81 'await_for_test': 'slow',
83 'bit_operations_test_none_multi': fail, // DDC/dart2js canonicalize bitop results to unsigned 82 'bit_operations_test_none_multi': fail, // DDC/dart2js canonicalize bitop results to unsigned
84 'branch_canonicalization_test': fail, // JS bit operations truncate to 32 bits. 83 'branch_canonicalization_test': fail, // JS bit operations truncate to 32 bits.
84 'call_test': fail,
Jennifer Messerly 2017/08/05 01:22:20 this is just triage for another language test migr
85 'call_closurization_test': fail, // Functions do not expose a "call" metho d. 85 'call_closurization_test': fail, // Functions do not expose a "call" metho d.
86 'canonical_const2_test': fail, 86 'canonical_const2_test': fail,
87 'canonical_const_test': fail, 87 'canonical_const_test': fail,
88 'compile_time_constant10_test_none_multi': fail, 88 'compile_time_constant10_test_none_multi': fail,
89 'compile_time_constant_a_test': fail, 89 'compile_time_constant_a_test': fail,
90 'compile_time_constant_b_test': fail, 90 'compile_time_constant_b_test': fail,
91 'compile_time_constant_d_test': fail, 91 'compile_time_constant_d_test': fail,
92 'compile_time_constant_k_test_none_multi': fail, 92 'compile_time_constant_k_test_none_multi': fail,
93 'compile_time_constant_o_test_none_multi': fail, 93 'compile_time_constant_o_test_none_multi': fail,
94 'const_evaluation_test_01_multi': fail, 94 'const_evaluation_test_01_multi': fail,
(...skipping 771 matching lines...) Expand 10 before | Expand all | Expand 10 after
866 866
867 for (let action of unittest_tests) { 867 for (let action of unittest_tests) {
868 try { 868 try {
869 action(); 869 action();
870 } catch (e) { 870 } catch (e) {
871 console.error("Caught error tying to setup test:", e); 871 console.error("Caught error tying to setup test:", e);
872 } 872 }
873 } 873 }
874 }); 874 });
875 }); 875 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698