Migrate language block 46 - canonical_const ... char_escape.

Migrate language block 46 - canonical_const ... char_escape.

R=jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/243d1c74eb0c7924540185e309862c88fca6fdae

[Bob Nystrom, 2017-08-04 22:45:51]

rnystrom@google.com changed reviewers:
+ jcollins@google.com, jmesserly@google.com

[Jennifer Messerly, 2017-08-04 23:02:06]

LGTM, did you test this in DDC?

./tools/test.py -m release -r chrome -c dartdevc --strong language_2

I'm triaging a few runtime failure right now in corelib_2 from earlier today
(one of them might be a DDC bug, one of them is the test not passing in strong
mode at runtime)

https://codereview.chromium.org/2996533003/diff/1/tests/language_2/cha_deopt2...
File tests/language_2/cha_deopt2_test.dart (right):

https://codereview.chromium.org/2996533003/diff/1/tests/language_2/cha_deopt2...
tests/language_2/cha_deopt2_test.dart:5: //
VMOptions=--optimization-counter-threshold=100 --no-background-compilation
--no-use-field-guards
just curious, what's this about? what does test.dart do when it sees two
VMOptions lines?

[Bob Nystrom, 2017-08-04 23:51:49]

On 2017/08/04 23:02:06, Jennifer Messerly wrote:
> LGTM, did you test this in DDC?
> 
> ./tools/test.py -m release -r chrome -c dartdevc --strong language_2

Yup!

[Bob Nystrom, 2017-08-04 23:52:16]

Description was changed from

==========
Migrate language block 46 - canonical_const ... char_escape.
==========

to

==========
Migrate language block 46 - canonical_const ... char_escape.

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/243d1c74eb0c7924540185e309862c88fca6fdae
==========

[Bob Nystrom, 2017-08-04 23:52:18]

Committed patchset #1 (id:1) manually as
243d1c74eb0c7924540185e309862c88fca6fdae (presubmit successful).

[Bob Nystrom, 2017-08-05 00:16:25]

https://codereview.chromium.org/2996533003/diff/1/tests/language_2/cha_deopt2...
File tests/language_2/cha_deopt2_test.dart (right):

https://codereview.chromium.org/2996533003/diff/1/tests/language_2/cha_deopt2...
tests/language_2/cha_deopt2_test.dart:5: //
VMOptions=--optimization-counter-threshold=100 --no-background-compilation
--no-use-field-guards
On 2017/08/04 23:02:06, Jennifer Messerly wrote:
> just curious, what's this about? what does test.dart do when it sees two
> VMOptions lines?

I think it runs the test twice, once with each info. See:

https://github.com/dart-lang/sdk/blob/master/tools/testing/dart/test_suite.da...