Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2996533002: Add utility tool to update .status files automatically (Closed)

Created:
3 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 4 months ago
Reviewers:
Emily Fortuna, sra1
CC:
reviews_dartlang.org, Bob Nystrom, sra1, Johnni Winther
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add utility tool to update .status files automatically Usage: from the Dart repo run: ./pkg/compiler/tool/status_files/update_all.sh Caveat: the bash script has only been tested in linux. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/78dc28606cf1debf20428b0f5b801aafe0106d41

Patch Set 1 #

Patch Set 2 : remove editbuffer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -0 lines) Patch
A pkg/compiler/tool/status_files/log_parser.dart View 1 chunk +50 lines, -0 lines 0 comments Download
A pkg/compiler/tool/status_files/record.dart View 1 chunk +50 lines, -0 lines 0 comments Download
A pkg/compiler/tool/status_files/update_all.sh View 1 chunk +46 lines, -0 lines 0 comments Download
A pkg/compiler/tool/status_files/update_from_log.dart View 1 1 chunk +217 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Siggi Cherem (dart-lang)
review at your discretion :), in particular: - update_all.sh and update_from_log.dart are the new additions ...
3 years, 4 months ago (2017-08-04 19:11:19 UTC) #3
sra1
lgtm
3 years, 4 months ago (2017-08-04 19:24:37 UTC) #6
Siggi Cherem (dart-lang)
thanks, as discussed I deleted editbuffer and now I'm just replacing a string in one ...
3 years, 4 months ago (2017-08-04 19:25:23 UTC) #7
Siggi Cherem (dart-lang)
3 years, 4 months ago (2017-08-04 19:26:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as
78dc28606cf1debf20428b0f5b801aafe0106d41 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698