test/cctest/test-heap-profiler.cc - Issue 299653002: Reland "Simplify debugger state."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 299653002: Reland "Simplify debugger state." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: fix test to check for pointer equality instead of handle equality Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-heap-profiler.cc

diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc

index eeafc7093cca7332579d0d9cee37273e9d354328..0417ace2c2bab5c32519e1534bdd8a5967f3facd 100644

--- a/test/cctest/test-heap-profiler.cc

+++ b/test/cctest/test-heap-profiler.cc

@@ -1888,7 +1888,7 @@ TEST(NoDebugObjectInSnapshot) {

v8::HandleScope scope(env->GetIsolate());

v8::HeapProfiler* heap_profiler = env->GetIsolate()->GetHeapProfiler();

- CcTest::i_isolate()->debug()->Load();

+ CHECK(CcTest::i_isolate()->debug()->Load());

CompileRun("foo = {};");

const v8::HeapSnapshot* snapshot =

heap_profiler->TakeHeapSnapshot(v8_str("snapshot"));

« no previous file with comments | « test/cctest/test-debug.cc ('k') | test/mjsunit/debug-stepin-positions.js » ('j') | no next file with comments »