src/runtime.cc - Issue 299653002: Reland "Simplify debugger state."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 299653002: Reland "Simplify debugger state." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: fix test to check for pointer equality instead of handle equality Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index d07d1a176b4405be784905bf252130dd95911e13..99dc6bfc406de1bc245c51fa302ab7d9ba32474c 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -11044,8 +11044,9 @@ RUNTIME_FUNCTION(Runtime_DebugIndexedInterceptorElementValue) {

static bool CheckExecutionState(Isolate* isolate, int break_id) {

- return (isolate->debug()->break_id() != 0 &&

- break_id == isolate->debug()->break_id());

+ return !isolate->debug()->debug_context().is_null() &&

+ isolate->debug()->break_id() != 0 &&

+ isolate->debug()->break_id() == break_id;

}

« no previous file with comments | « src/isolate.cc ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »