Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2996523003: Fix incorrect nullability inference for ?? (Closed)

Created:
3 years, 4 months ago by Leaf
Modified:
3 years, 4 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix incorrect nullability inference for ?? Fix bug where (a?.foo) was being incorrectly inferred to be non-nullable if `foo` was non-nullable. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/d3344ed466c87467034a2faaf98bc2fc15090281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M pkg/dev_compiler/lib/src/compiler/nullable_type_inference.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/language_strong/nullaware_opt_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Leaf
3 years, 4 months ago (2017-08-04 22:18:47 UTC) #2
Jennifer Messerly
lgtm
3 years, 4 months ago (2017-08-04 22:25:04 UTC) #3
Leaf
3 years, 4 months ago (2017-08-04 22:31:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d3344ed466c87467034a2faaf98bc2fc15090281 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698