Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2996513002: Migrated test block 12 to Dart 2.0. (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom, jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 12 to Dart 2.0. Modified json_map_test to not expect the maps to be of type Map<int, dynamic>, and marked iterable_to_list_test and iterable_to_set_test as failing on DDC in the status files. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/df3238ef2dccdda467d6685d868bdf4c6da77ddf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2214 lines) Patch
M tests/corelib/corelib.status View 2 chunks +0 lines, -10 lines 0 comments Download
D tests/corelib/iterable_skip_while_test.dart View 1 chunk +0 lines, -146 lines 0 comments Download
D tests/corelib/iterable_take_test.dart View 1 chunk +0 lines, -227 lines 0 comments Download
D tests/corelib/iterable_take_while_test.dart View 1 chunk +0 lines, -130 lines 0 comments Download
D tests/corelib/iterable_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/corelib/iterable_to_list_test.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D tests/corelib/iterable_to_set_test.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D tests/corelib/iterable_tostring_test.dart View 1 chunk +0 lines, -106 lines 0 comments Download
D tests/corelib/json_map_test.dart View 1 chunk +0 lines, -334 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 5 chunks +14 lines, -0 lines 0 comments Download
A + tests/corelib_2/iterable_skip_while_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/iterable_take_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/iterable_take_while_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/iterable_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/iterable_to_list_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/iterable_to_set_test.dart View 2 chunks +9 lines, -9 lines 0 comments Download
A + tests/corelib_2/iterable_tostring_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/json_map_test.dart View 2 chunks +3 lines, -11 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 2 chunks +0 lines, -3 lines 0 comments Download
M tests/corelib_strong/corelib_strong_kernel.status View 1 chunk +0 lines, -3 lines 0 comments Download
D tests/corelib_strong/iterable_skip_while_test.dart View 1 chunk +0 lines, -146 lines 0 comments Download
D tests/corelib_strong/iterable_take_test.dart View 1 chunk +0 lines, -227 lines 0 comments Download
D tests/corelib_strong/iterable_take_while_test.dart View 1 chunk +0 lines, -130 lines 0 comments Download
D tests/corelib_strong/iterable_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/corelib_strong/iterable_to_list_test.dart View 1 chunk +0 lines, -67 lines 0 comments Download
D tests/corelib_strong/iterable_to_set_test.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D tests/corelib_strong/iterable_tostring_test.dart View 1 chunk +0 lines, -106 lines 0 comments Download
D tests/corelib_strong/json_map_test.dart View 1 chunk +0 lines, -350 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
3 years, 4 months ago (2017-08-04 18:11:56 UTC) #2
Bob Nystrom
lgtm
3 years, 4 months ago (2017-08-04 19:32:04 UTC) #3
bkonyi
3 years, 4 months ago (2017-08-04 20:34:55 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
df3238ef2dccdda467d6685d868bdf4c6da77ddf.

Powered by Google App Engine
This is Rietveld 408576698