Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2549)

Unified Diff: dashboard/dashboard/pinpoint/models/quest/read_value_test.py

Issue 2996473002: [pinpoint] Add QuestGenerator object. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/pinpoint/models/quest/read_value_test.py
diff --git a/dashboard/dashboard/pinpoint/models/quest/read_value_test.py b/dashboard/dashboard/pinpoint/models/quest/read_value_test.py
index e2a69d6db231f2abaebeaf32c8c4d4494f27778d..972eef56e7da7edd20406de44dc4295eee929a58 100644
--- a/dashboard/dashboard/pinpoint/models/quest/read_value_test.py
+++ b/dashboard/dashboard/pinpoint/models/quest/read_value_test.py
@@ -11,9 +11,9 @@ from dashboard.pinpoint.models.quest import read_value
@mock.patch('dashboard.services.isolate_service.Retrieve')
-class ReadValueTest(unittest.TestCase):
+class ReadChartJsonValueTest(unittest.TestCase):
- def testReadValue(self, retrieve):
+ def testReadChartJsonValue(self, retrieve):
retrieve.side_effect = (
{'files': {'chartjson-output.json': {'h': 'chartjson hash'}}},
json.dumps({'charts': {'metric': {'test': {
@@ -22,7 +22,8 @@ class ReadValueTest(unittest.TestCase):
}}}}),
)
- execution = read_value.ReadValue('metric', 'test').Start('output hash')
+ quest = read_value.ReadChartJsonValue('metric', 'test')
+ execution = quest.Start('output hash')
execution.Poll()
self.assertTrue(execution.completed)
@@ -33,7 +34,7 @@ class ReadValueTest(unittest.TestCase):
expected_calls = [mock.call('output hash'), mock.call('chartjson hash')]
self.assertEqual(retrieve.mock_calls, expected_calls)
- def testReadValueWithNoTest(self, retrieve):
+ def testReadChartJsonValueWithNoTest(self, retrieve):
retrieve.side_effect = (
{'files': {'chartjson-output.json': {'h': 'chartjson hash'}}},
json.dumps({'charts': {'metric': {'summary': {
@@ -42,7 +43,8 @@ class ReadValueTest(unittest.TestCase):
}}}}),
)
- execution = read_value.ReadValue('metric', None).Start('output hash')
+ quest = read_value.ReadChartJsonValue('metric', None)
+ execution = quest.Start('output hash')
execution.Poll()
self.assertTrue(execution.completed)
@@ -65,7 +67,8 @@ class ReadValueTest(unittest.TestCase):
}}}}),
)
- execution = read_value.ReadValue('metric', 'test').Start('output hash')
+ quest = read_value.ReadChartJsonValue('metric', 'test')
+ execution = quest.Start('output hash')
execution.Poll()
self.assertEqual(execution.result_values, (0, 0, 1, 1, 1))
@@ -82,7 +85,8 @@ class ReadValueTest(unittest.TestCase):
}}}}),
)
- execution = read_value.ReadValue('metric', 'test').Start('output hash')
+ quest = read_value.ReadChartJsonValue('metric', 'test')
+ execution = quest.Start('output hash')
execution.Poll()
self.assertEqual(execution.result_values, tuple([0] * 4000 + [1] * 6000))
@@ -96,7 +100,8 @@ class ReadValueTest(unittest.TestCase):
}}}}),
)
- execution = read_value.ReadValue('metric', 'test').Start('output hash')
+ quest = read_value.ReadChartJsonValue('metric', 'test')
+ execution = quest.Start('output hash')
execution.Poll()
self.assertEqual(execution.result_values, (2.5,))

Powered by Google App Engine
This is Rietveld 408576698