[pinpoint] Add QuestGenerator object.

dashboard/dashboard/pinpoint/models/job.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import logging
 import os
 
 from google.appengine.api import taskqueue
 from google.appengine.ext import ndb
 
 from dashboard.common import utils
 from dashboard.pinpoint import mann_whitney_u
 from dashboard.pinpoint.models import attempt as attempt_module
 from dashboard.pinpoint.models import change as change_module
-from dashboard.pinpoint.models import quest as quest_module
 from dashboard.services import issue_tracker_service
 
 
 # We want this to be fast to minimize overhead while waiting for tasks to
 # finish, but don't want to consume too many resources.
 _TASK_INTERVAL = 10
 
 
 _DEFAULT_REPEAT_COUNT = 10
 _DEFAULT_ATTEMPT_COUNT = 1
@@ skipping 24 matching lines @@
 
   # The name of the Task Queue task this job is running on. If it's present, the
   # job is running. The task is also None for Task Queue retries.
   task = ndb.StringProperty()
 
   # The string contents of any Exception that was thrown to the top level.
   # If it's present, the job failed.
   exception = ndb.StringProperty()
 
   # Request parameters.
-  configuration = ndb.StringProperty(required=True)
-  test_suite = ndb.StringProperty()
-  test = ndb.StringProperty()
-  metric = ndb.StringProperty()
+  arguments = ndb.JsonProperty(required=True)
 
   # If True, the service should pick additional Changes to run (bisect).
   # If False, only run the Changes explicitly added by the user.
   auto_explore = ndb.BooleanProperty(required=True)
 
   # TODO: The bug id is only used for posting bug comments when a job starts and
   # completes. This probably should not be the responsibility of Pinpoint.
   bug_id = ndb.IntegerProperty()
 
   state = ndb.PickleProperty(required=True)
 
   @classmethod
-  def New(cls, configuration, test_suite, test, metric, auto_explore, bug_id):
-    # Get list of quests.
-    quests = [quest_module.FindIsolate(configuration)]
-    if test_suite:
-      quests.append(quest_module.RunTest(configuration, test_suite, test,
-                                         _DEFAULT_REPEAT_COUNT))
-    if metric:
-      quests.append(quest_module.ReadValue(metric, test))
-
+  def New(cls, arguments, quests, auto_explore, bug_id):
     # Create job.
     return cls(
-        configuration=configuration,
-        test_suite=test_suite,
-        test=test,
-        metric=metric,
+        arguments=arguments,
         auto_explore=auto_explore,
         bug_id=bug_id,
         state=_JobState(quests, _DEFAULT_ATTEMPT_COUNT))
 
   @property
   def job_id(self):
     return self.key.urlsafe()
 
   @property
   def status(self):
@@ skipping 54 matching lines @@
       else:
         self.Complete()
     except BaseException as e:
       self.Fail(e)
       raise
 
   def AsDict(self):
     return {
         'job_id': self.job_id,
 
-        'configuration': self.configuration,
-        'test_suite': self.test_suite,
-        'test': self.test,
-        'metric': self.metric,
+        'arguments': self.arguments,
         'auto_explore': self.auto_explore,
 
         'created': self.created.strftime('%Y-%m-%d %H:%M:%S %Z'),
         'updated': self.updated.strftime('%Y-%m-%d %H:%M:%S %Z'),
         'status': self.status,
 
         'state': self.state.AsDict(),
     }
 
 
@@ skipping 157 matching lines @@
 
   try:
     p_value = mann_whitney_u.MannWhitneyU(results_a, results_b)
   except ValueError:
     return _UNKNOWN
 
   if p_value < _SIGNIFICANCE_LEVEL:
     return _DIFFERENT
   else:
     return _UNKNOWN