[pinpoint] Add QuestGenerator object.

dashboard/dashboard/pinpoint/handlers/new_test.py

 # Copyright 2017 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 
 import mock
 import webapp2
 import webtest
 
 from google.appengine.api import users
 
 from dashboard.api import api_auth
 from dashboard.common import namespaced_stored_object
 from dashboard.common import testing_common
 from dashboard.common import utils
 from dashboard.services import gitiles_service
 from dashboard.pinpoint.handlers import new
 from dashboard.pinpoint.models import job as job_module
+from dashboard.pinpoint.models import test_config
 
 AUTHORIZED_USER = users.User(email='authorized_person@chromium.org',
                              _auth_domain='google.com')
 UNAUTHORIZED_USER = users.User(email='foo@bar.com', _auth_domain='bar.com')
 
 
 class NewTest(testing_common.TestCase):
 
   def setUp(self):
     super(NewTest, self).setUp()
@@ skipping 51 matching lines @@
   @mock.patch.object(gitiles_service, 'CommitInfo', mock.MagicMock())
   @mock.patch.object(gitiles_service, 'CommitRange')
   def testPost(self, mock_commit_range):
     mock_commit_range.return_value = [
         {'commit': '1'},
         {'commit': '2'},
         {'commit': '3'},
     ]
     params = {
         'configuration': 'chromium-rel-mac11-pro',
-        'test_suite': 'speedometer',
-        'test': '',
-        'metric': 'Total',
+        'target': 'telemetry_perf_tests',
+        'dimensions': '{}',
+        'benchmark': 'speedometer',
         'auto_explore': '1',
         'bug_id': 12345,
         'start_repository': 'src',
         'start_git_hash': '1',
         'end_repository': 'src',
         'end_git_hash': '3'
     }
     response = self.testapp.post('/api/new', params, status=200)
     result = json.loads(response.body)
     self.assertIn('jobId', result)
     self.assertEqual(
         result['jobUrl'],
         'https://testbed.example.com/job/%s' % result['jobId'])
 
-  def testPost_MetricButNoTestSuite(self):
+  def testPost_InvalidTestConfig(self):
     params = {
         'configuration': 'chromium-rel-mac11-pro',
-        'test_suite': '',
-        'test': '',
-        'metric': 'Total',
+        'target': 'telemetry_perf_tests',
+        'dimensions': '{}',
+        # telemetry_perf_tests requires a benchmark field, which is missing.
         'auto_explore': '1',
         'bug_id': 12345,
         'start_repository': 'src',
         'start_git_hash': '1',
         'end_repository': 'src',
         'end_git_hash': '3'
     }
     response = self.testapp.post('/api/new', params, status=200)
-    self.assertEqual({'error': new._ERROR_METRIC_NO_TEST_SUITE},
+    self.assertEqual({'error': test_config._ERROR_NO_BENCHMARK},
                      json.loads(response.body))
 
   @mock.patch.object(
       gitiles_service, 'CommitInfo',
-      mock.MagicMock(side_effect=gitiles_service.NotFoundError))
+      mock.MagicMock(side_effect=gitiles_service.NotFoundError('message')))
   def testPost_InvalidChange(self):
     params = {
         'configuration': 'chromium-rel-mac11-pro',
-        'test_suite': 'speedometer',
-        'test': '',
-        'metric': 'Total',
         'auto_explore': '1',
         'bug_id': 12345,
         'start_repository': 'src',
         'start_git_hash': '1',
         'end_repository': 'src',
         'end_git_hash': '3'
     }
     response = self.testapp.post('/api/new', params, status=200)
-    self.assertEqual({'error': 'NotFoundError()'},
+    self.assertEqual({'error': 'message'},
                      json.loads(response.body))
 
   def testPost_InvalidBug(self):
     params = {
         'configuration': 'chromium-rel-mac11-pro',
-        'test_suite': 'speedometer',
-        'test': '',
-        'metric': 'Total',
         'auto_explore': '1',
         'bug_id': 'not_an_int',
         'start_repository': 'src',
         'start_git_hash': '1',
         'end_repository': 'src',
         'end_git_hash': '3'
     }
     response = self.testapp.post('/api/new', params, status=200)
     self.assertEqual({'error': new._ERROR_BUG_ID},
                      json.loads(response.body))
 
   @mock.patch(
       'dashboard.services.issue_tracker_service.IssueTrackerService',
       mock.MagicMock())
   @mock.patch.object(utils, 'ServiceAccountHttp', mock.MagicMock())
   @mock.patch.object(gitiles_service, 'CommitInfo', mock.MagicMock())
   @mock.patch.object(gitiles_service, 'CommitRange')
   def testPost_EmptyBug(self, mock_commit_range):
     mock_commit_range.return_value = [
         {'commit': '1'},
         {'commit': '2'},
         {'commit': '3'},
     ]
     params = {
         'configuration': 'chromium-rel-mac11-pro',
-        'test_suite': 'speedometer',
-        'test': '',
-        'metric': 'Total',
         'auto_explore': '1',
         'bug_id': '',
         'start_repository': 'src',
         'start_git_hash': '1',
         'end_repository': 'src',
         'end_git_hash': '3'
     }
     response = self.testapp.post('/api/new', params, status=200)
     result = json.loads(response.body)
     self.assertIn('jobId', result)
     self.assertEqual(
         result['jobUrl'],
         'https://testbed.example.com/job/%s' % result['jobId'])
     job = job_module.Job.query().get()
     self.assertEqual(None, job.bug_id)