Make minification Entity-friendly.

Make minification Entity-friendly.


BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/4929f282b395888b2d93991e32212abf7c584a53

[Emily Fortuna, 2017-08-03 23:35:37]

efortuna@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-08-03 23:44:54]

lgtm!

https://codereview.chromium.org/2996463002/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/field_naming_mixin.dart (right):

https://codereview.chromium.org/2996463002/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/field_naming_mixin.dart:23: names = new
_FieldNamingScope.forBox(element.box, fieldRegistry);
this might trigger some unhappy analyzer in strong mode tests, you might need to
add here: (element as dynamic).box

The alternative would be to duplicate the code twice:
if (... is BoxFieldElement) {
} else if (... is JBoxedField) {
...
}

[Emily Fortuna, 2017-08-04 01:34:47]

Patchset #5 (id:80001) has been deleted

[Emily Fortuna, 2017-08-04 01:35:04]

https://codereview.chromium.org/2996463002/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/field_naming_mixin.dart (right):

https://codereview.chromium.org/2996463002/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/field_naming_mixin.dart:23: names = new
_FieldNamingScope.forBox(element.box, fieldRegistry);
On 2017/08/03 23:44:54, Siggi Cherem (dart-lang) wrote:
> this might trigger some unhappy analyzer in strong mode tests, you might need
to
> add here: (element as dynamic).box
> 
> The alternative would be to duplicate the code twice:
> if (... is BoxFieldElement) {
> } else if (... is JBoxedField) {
> ...
> }

yes, sorry about that. Just ran the analyzer tests and am fixing that now.

[Emily Fortuna, 2017-08-04 01:35:12]

Patchset #3 (id:40001) has been deleted

[Emily Fortuna, 2017-08-04 01:35:18]

Patchset #2 (id:20001) has been deleted

[Emily Fortuna, 2017-08-04 01:35:26]

Patchset #1 (id:1) has been deleted

[Emily Fortuna, 2017-08-04 02:19:26]

Description was changed from

==========
Make minification Entity-friendly.


BUG=
==========

to

==========
Make minification Entity-friendly.


BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4929f282b395888b2d93991e32212abf7c584a53
==========

[Emily Fortuna, 2017-08-04 02:19:27]

Committed patchset #2 (id:100001) manually as
4929f282b395888b2d93991e32212abf7c584a53 (presubmit successful).