Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 299633002: Fix BrowserActionButton's hover state in ToolbarController (Closed)

Created:
6 years, 7 months ago by Xuefei Ren
Modified:
6 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix BrowserActionButton's hover state in ToolbarController. The cell was changed from GradientButtonCell to ImageButtonCell. GradientButtonCell has setMouseInside:animate:, but for ImageButtonCell this method is called setIsMouseInside: BUG=373662 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273183

Patch Set 1 #

Patch Set 2 : Fix BrowserActionButton's hover state in ToolbarController. #

Patch Set 3 : fix conflit with AUTHORS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
Xuefei Ren
bug=373662 Sorry for the style, this is my patch here.
6 years, 7 months ago (2014-05-20 06:13:21 UTC) #1
Nico
lgtm, thanks! (A slightly more detailed description would've been nice, something like "the cell was ...
6 years, 7 months ago (2014-05-21 19:17:02 UTC) #2
Nico
(You can hit the "Commit" checkbox to land this.)
6 years, 7 months ago (2014-05-21 19:17:20 UTC) #3
Xuefei Ren
The CQ bit was checked by xrenishere@gmail.com
6 years, 7 months ago (2014-05-22 01:14:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xrenishere@gmail.com/299633002/1
6 years, 7 months ago (2014-05-22 01:17:27 UTC) #5
Xuefei Ren
The CQ bit was unchecked by xrenishere@gmail.com
6 years, 7 months ago (2014-05-22 07:00:53 UTC) #6
Xuefei Ren
The CQ bit was checked by xrenishere@gmail.com
6 years, 7 months ago (2014-05-27 09:10:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xrenishere@gmail.com/299633002/10001
6 years, 7 months ago (2014-05-27 09:11:17 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-27 12:16:53 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 12:42:05 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77871)
6 years, 7 months ago (2014-05-27 12:42:06 UTC) #11
Xuefei Ren
The CQ bit was checked by xrenishere@gmail.com
6 years, 7 months ago (2014-05-28 02:12:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xrenishere@gmail.com/299633002/10001
6 years, 7 months ago (2014-05-28 02:13:49 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 7 months ago (2014-05-28 02:45:26 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-28 03:17:48 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/78305)
6 years, 7 months ago (2014-05-28 03:17:49 UTC) #16
Xuefei Ren
The CQ bit was unchecked by xrenishere@gmail.com
6 years, 7 months ago (2014-05-28 03:19:05 UTC) #17
Xuefei Ren
The CQ bit was checked by xrenishere@gmail.com
6 years, 7 months ago (2014-05-28 03:23:34 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xrenishere@gmail.com/299633002/30001
6 years, 7 months ago (2014-05-28 03:24:16 UTC) #19
Xuefei Ren
The CQ bit was unchecked by xrenishere@gmail.com
6 years, 7 months ago (2014-05-28 08:17:47 UTC) #20
Xuefei Ren
The CQ bit was checked by xrenishere@gmail.com
6 years, 7 months ago (2014-05-28 08:18:00 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xrenishere@gmail.com/299633002/30001
6 years, 7 months ago (2014-05-28 08:18:40 UTC) #22
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 08:46:59 UTC) #23
Message was sent while issue was closed.
Change committed as 273183

Powered by Google App Engine
This is Rietveld 408576698