Issue 2996243003: Reapply "[vm] Prevent non-fatal errors from causing timers to be dropped."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2996243003: Reapply "[vm] Prevent non-fatal errors from causing timers to be dropped." (Closed)

Created:
3 years, 4 months ago by rmacnak

Modified:
3 years, 4 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Reapply "[vm] Prevent non-fatal errors from causing timers to be dropped." Fix Linux event handler to re-arm the timer_fd after handling a wakeup. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/60a7160273f881304a03875cb9c16e8d7b791ab9

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -10 lines)			Patch
M	runtime/bin/eventhandler_linux.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/eventhandler_linux.cc	View	3 chunks	+14 lines, -9 lines	0 comments	Download
M	runtime/lib/timer_impl.dart	View	2 chunks	+8 lines, -1 line	0 comments	Download
A	tests/isolate/non_fatal_exception_in_timer_callback_test.dart	View	1 chunk	+27 lines, -0 lines	0 comments	Download
A	tests/isolate/timer_multiple_isolates_test.dart	View	1 chunk	+42 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

3 years, 4 months ago (2017-08-18 20:38:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
60a7160273f881304a03875cb9c16e8d7b791ab9 (presubmit successful).