Issue 299623002: Do not guard glib code using OS_POSIX flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 299623002: Do not guard glib code using OS_POSIX flag. (Closed)

Created:
6 years, 7 months ago by joone

Modified:
6 years, 7 months ago

Reviewers:
Lei Zhang, Ryan Hamilton, akalin

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Do not guard glib code using OS_POSIX flag. USE_GLIB should be used instead of OS_POSIX. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272266

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	net/tools/net_watcher/net_watcher.cc	View		3 chunks	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

joone

On 2014/05/20 05:43:36, joone wrote: > Could you review this patch? The patch allows to ...

6 years, 7 months ago (2014-05-20 05:48:20 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joone.hur@intel.com/299623002/1

6 years, 7 months ago (2014-05-22 15:19:26 UTC) #5

Lei Zhang

6 years, 7 months ago (2014-05-22 23:59:07 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/299623002/diff/1/net/tools/net_watcher/net_wa...
File net/tools/net_watcher/net_watcher.cc (right):

https://codereview.chromium.org/299623002/diff/1/net/tools/net_watcher/net_wa...
net/tools/net_watcher/net_watcher.cc:24: #if defined(USE_GLIB) &&
!defined(OS_MACOSX) && !defined(OS_ANDROID) && !defined(OS_CHROMEOS)
This should just be #if defined(USE_GLIB). I have a CL that will fix this.

Expand Messages | Collapse Messages