Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2996153002: Reland of Add a flags field to video timing extension. (Closed)

Created:
3 years, 4 months ago by sprang_webrtc
Modified:
3 years, 4 months ago
Reviewers:
ilnik
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, kwiberg-webrtc, the sun, mflodman, kthelgason, emircan1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add a flags field to video timing extension. (patchset #1 id:1 of https://codereview.webrtc.org/2995953002/ ) Reason for revert: Create reland CL to add fix to. Original issue's description: > Revert of Add a flags field to video timing extension. (patchset #15 id:280001 of https://codereview.webrtc.org/3000753002/ ) > > Reason for revert: > Speculative revet for breaking remoting_unittests in fyi bots. > https://build.chromium.org/p/chromium.webrtc.fyi/waterfall?builder=Win7%20Tester > > Original issue's description: > > Add a flags field to video timing extension. > > > > The rtp header extension for video timing shuold have an additional > > field for signaling metadata, such as what triggered the extension for > > this particular frame. This will allow separating frames select because > > of outlier sizes from regular frames, for more accurate stats. > > > > This implementation is backwards compatible in that it can read video > > timing extensions without the new flag field, but it always sends with > > it included. > > > > BUG=webrtc:7594 > > > > Review-Url: https://codereview.webrtc.org/3000753002 > > Cr-Commit-Position: refs/heads/master@{#19353} > > Committed: https://chromium.googlesource.com/external/webrtc/+/cf5d485e147f7d7b3081692f101e496ce9e1d257 > > TBR=danilchap@webrtc.org,kthelgason@webrtc.org,stefan@webrtc.org,sprang@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7594 > > Review-Url: https://codereview.webrtc.org/2995953002 > Cr-Commit-Position: refs/heads/master@{#19360} > Committed: https://chromium.googlesource.com/external/webrtc/+/f0f7378b059501bb2bc5d006bf0f43546e47328f TBR=danilchap@webrtc.org,kthelgason@webrtc.org,stefan@webrtc.org,emircan@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7594 Review-Url: https://codereview.webrtc.org/2996153002 Cr-Commit-Position: refs/heads/master@{#19405} Committed: https://chromium.googlesource.com/external/webrtc/+/ba050a6d6d60690141f2dd23c824857e690d1991

Patch Set 1 #

Patch Set 2 : Only allow timing frames if encode start time is present #

Patch Set 3 : Added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -83 lines) Patch
M webrtc/api/video/video_timing.h View 1 5 chunks +32 lines, -7 lines 0 comments Download
M webrtc/api/video/video_timing.cc View 1 2 chunks +25 lines, -7 lines 0 comments Download
M webrtc/common_video/include/video_frame.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_video/video_frame.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc View 1 2 chunks +46 lines, -25 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_to_send.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_unittest.cc View 1 3 chunks +67 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 4 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/encoded_frame.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/frame_buffer.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/frame_object.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/generic_decoder.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/generic_encoder.cc View 1 3 chunks +9 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/generic_encoder_unittest.cc View 1 2 2 chunks +27 lines, -1 line 0 comments Download
M webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCEncodedImage.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/payload_router.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/video/rtp_video_stream_receiver.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
sprang_webrtc
Created Reland of Add a flags field to video timing extension.
3 years, 4 months ago (2017-08-17 13:56:55 UTC) #1
sprang_webrtc
ilnik@, ptal The first patch set is the plain reland. The second contains the fix ...
3 years, 4 months ago (2017-08-17 15:05:15 UTC) #3
ilnik
On 2017/08/17 15:05:15, sprang_webrtc wrote: > ilnik@, ptal > The first patch set is the ...
3 years, 4 months ago (2017-08-17 15:24:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2996153002/460001
3 years, 4 months ago (2017-08-18 08:42:18 UTC) #6
commit-bot: I haz the power
3 years, 4 months ago (2017-08-18 09:51:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:460001) as
https://chromium.googlesource.com/external/webrtc/+/ba050a6d6d60690141f2dd23c...

Powered by Google App Engine
This is Rietveld 408576698