Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2995973002: Gardening: Revert "fix #30423, covariant parameter tearoff type should be Object" (TBR) (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 4 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Gardening: Revert "fix #30423, covariant parameter tearoff type should be Object" (TBR) Committed: https://github.com/dart-lang/sdk/commit/1b0b1a49133f395332106cc6a7883d75947d94e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -108 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 6 chunks +12 lines, -30 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/closure.js View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/covariant_subtyping_test.dart View 2 chunks +0 lines, -27 lines 0 comments Download
M tests/language_strong/function_subtype2_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/language_strong/function_subtype3_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/language_strong/function_subtype_bound_closure3_test.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M tests/language_strong/function_subtype_bound_closure4_test.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/language_strong/function_subtype_call1_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/language_strong/function_subtype_call2_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/language_strong/function_subtype_cast1_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language_strong/function_subtype_not1_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language_strong/function_type_alias2_test.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M tests/language_strong/language_strong.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Brian Wilkerson
This appears to have broken the ddc bots. See https://build.chromium.org/p/client.dart/builders/ddc-linux-release-be/builds/157/steps/ddc%20tests/logs/stdio for the failure messages.
3 years, 4 months ago (2017-08-16 00:02:25 UTC) #2
Brian Wilkerson
3 years, 4 months ago (2017-08-16 00:02:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b0b1a49133f395332106cc6a7883d75947d94e4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698