Issue 2995963002: refactor AstBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2995963002: refactor AstBuilder (Closed)

Created:
3 years, 4 months ago by danrubel

Modified:
3 years, 4 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, scheglov

Target Ref:
refs/heads/master

Visibility:
Public.

refactor AstBuilder Refactor the AstBuilder to use scriptTag, directives, and declarations fields rather than pushing top level nodes on a generic stack and later popping and sorting objects from the that generic stack. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/6a958b3edbcd68a2d6b7d697477f3b2b12619d03

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -48 lines)			Patch
M	pkg/analyzer/lib/src/fasta/ast_builder.dart	View	1	17 chunks	+23 lines, -42 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_fasta_test.dart	View		2 chunks	+12 lines, -5 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/source/stack_listener.dart	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

danrubel

3 years, 4 months ago (2017-08-16 13:47:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
6a958b3edbcd68a2d6b7d697477f3b2b12619d03 (presubmit successful).