Update incremental load example so you can point to different sdk

Update incremental load example so you can point it at different(flutter) sdk.

This allows to run flutter gallery example through incremental compiler(it assumes you built android_debug flutter/engine and have fetched flutter/flutter):

$HOME/p/d/dart-sdk/sdk/out/DebugX64/dart --packages=$HOME/p/d/dart-sdk/sdk/.packages $HOME/p/d/dart-sdk/sdk/pkg/front_end/example/incremental_reload/run.dart  --sdk-root=$HOME/p/f/t11/flutter/engine/src/out/android_debug/flutter_patched_sdk --input $HOME/p/f/t11/flutter/flutter/examples/flutter_gallery/lib/main.dart

which crashes with

R=sigmund@google.com

  error: compilation error: dart:_builtin: Internal problem: Unhandled null in builder.library., #0      internalProblem (package:front_end/src/fasta/problems.dart:29:3)
#1      unhandled (package:front_end/src/fasta/problems.dart:41:10)
#2      DillLoader.buildOutline (package:front_end/src/fasta/dill/dill_loader.dart:47:7)
<asynchronous suspension>
...
Committed: https://github.com/dart-lang/sdk/commit/69d9c26416822807dd5f5deeecc5ba2b2a7a4035

[aam, 2017-08-14 23:34:44]

Description was changed from

==========
Update incremental load example so you can point to different sdk

BUG=
==========

to

==========
Update incremental load example so you can point it at different(flutter) sdk.

This allows to run flutter gallery example through incremental compiler(it
assumes you built android_debug flutter/engine and have fetched
flutter/flutter):

$HOME/p/d/dart-sdk/sdk/out/DebugX64/dart
--packages=$HOME/p/d/dart-sdk/sdk/.packages
$HOME/p/d/dart-sdk/sdk/pkg/front_end/example/incremental_reload/run.dart 
--sdk-root=$HOME/p/f/t11/flutter/engine/src/out/android_debug/flutter_patched_sdk
--input $HOME/p/f/t11/flutter/flutter/examples/flutter_gallery/lib/main.dart

which crashes with 

  error: compilation error: dart:_builtin: Internal problem: Unhandled null in
builder.library., #0      internalProblem
(package:front_end/src/fasta/problems.dart:29:3)
#1      unhandled (package:front_end/src/fasta/problems.dart:41:10)
#2      DillLoader.buildOutline
(package:front_end/src/fasta/dill/dill_loader.dart:47:7)
<asynchronous suspension>
...
==========

[aam, 2017-08-14 23:34:45]

aam@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-08-15 00:37:15]

small suggestions but otherwise lgtm.

I think this crashes for you because you may need to specify a different target
(it is using the vm target by default, you probably need the flutter target
instead).

https://codereview.chromium.org/2995913002/diff/1/pkg/front_end/example/incre...
File pkg/front_end/example/incremental_reload/compiler_with_invalidation.dart
(right):

https://codereview.chromium.org/2995913002/diff/1/pkg/front_end/example/incre...
pkg/front_end/example/incremental_reload/compiler_with_invalidation.dart:26:
{bool persistent: true, Uri argSdkRoot}) {
nit: rename to sdkRoot, possibly remove the TODO :) above?

https://codereview.chromium.org/2995913002/diff/1/pkg/front_end/example/incre...
File pkg/front_end/example/incremental_reload/run.dart (right):

https://codereview.chromium.org/2995913002/diff/1/pkg/front_end/example/incre...
pkg/front_end/example/incremental_reload/run.dart:57: ..addOption('input', help:
'Input dart file')
minor suggestion: let's remove this option and use `options.rest` below to get
the input

https://codereview.chromium.org/2995913002/diff/1/pkg/front_end/example/incre...
pkg/front_end/example/incremental_reload/run.dart:58: ..addOption('output',
help: 'Output dill file', defaultsTo: 'out.dill');
minor suggestion: let's add `abbr: "o"`

[aam, 2017-08-15 03:59:49]

Added --target option, and now flutter gallery app compiles fine with `--target
flutter`

https://codereview.chromium.org/2995913002/diff/1/pkg/front_end/example/incre...
File pkg/front_end/example/incremental_reload/compiler_with_invalidation.dart
(right):

https://codereview.chromium.org/2995913002/diff/1/pkg/front_end/example/incre...
pkg/front_end/example/incremental_reload/compiler_with_invalidation.dart:26:
{bool persistent: true, Uri argSdkRoot}) {
On 2017/08/15 00:37:14, Siggi Cherem (dart-lang) wrote:
> nit: rename to sdkRoot, possibly remove the TODO :) above?

Done.

https://codereview.chromium.org/2995913002/diff/1/pkg/front_end/example/incre...
File pkg/front_end/example/incremental_reload/run.dart (right):

https://codereview.chromium.org/2995913002/diff/1/pkg/front_end/example/incre...
pkg/front_end/example/incremental_reload/run.dart:57: ..addOption('input', help:
'Input dart file')
On 2017/08/15 00:37:14, Siggi Cherem (dart-lang) wrote:
> minor suggestion: let's remove this option and use `options.rest` below to get
> the input

Done.

https://codereview.chromium.org/2995913002/diff/1/pkg/front_end/example/incre...
pkg/front_end/example/incremental_reload/run.dart:58: ..addOption('output',
help: 'Output dill file', defaultsTo: 'out.dill');
On 2017/08/15 00:37:15, Siggi Cherem (dart-lang) wrote:
> minor suggestion: let's add `abbr: "o"`

Done.

[aam, 2017-08-15 04:04:34]

Description was changed from

==========
Update incremental load example so you can point it at different(flutter) sdk.

This allows to run flutter gallery example through incremental compiler(it
assumes you built android_debug flutter/engine and have fetched
flutter/flutter):

$HOME/p/d/dart-sdk/sdk/out/DebugX64/dart
--packages=$HOME/p/d/dart-sdk/sdk/.packages
$HOME/p/d/dart-sdk/sdk/pkg/front_end/example/incremental_reload/run.dart 
--sdk-root=$HOME/p/f/t11/flutter/engine/src/out/android_debug/flutter_patched_sdk
--input $HOME/p/f/t11/flutter/flutter/examples/flutter_gallery/lib/main.dart

which crashes with 

  error: compilation error: dart:_builtin: Internal problem: Unhandled null in
builder.library., #0      internalProblem
(package:front_end/src/fasta/problems.dart:29:3)
#1      unhandled (package:front_end/src/fasta/problems.dart:41:10)
#2      DillLoader.buildOutline
(package:front_end/src/fasta/dill/dill_loader.dart:47:7)
<asynchronous suspension>
...
==========

to

==========
Update incremental load example so you can point it at different(flutter) sdk.

This allows to run flutter gallery example through incremental compiler(it
assumes you built android_debug flutter/engine and have fetched
flutter/flutter):

$HOME/p/d/dart-sdk/sdk/out/DebugX64/dart
--packages=$HOME/p/d/dart-sdk/sdk/.packages
$HOME/p/d/dart-sdk/sdk/pkg/front_end/example/incremental_reload/run.dart 
--sdk-root=$HOME/p/f/t11/flutter/engine/src/out/android_debug/flutter_patched_sdk
--input $HOME/p/f/t11/flutter/flutter/examples/flutter_gallery/lib/main.dart

which crashes with

R=sigmund@google.com

  error: compilation error: dart:_builtin: Internal problem: Unhandled null in
builder.library., #0      internalProblem
(package:front_end/src/fasta/problems.dart:29:3)
#1      unhandled (package:front_end/src/fasta/problems.dart:41:10)
#2      DillLoader.buildOutline
(package:front_end/src/fasta/dill/dill_loader.dart:47:7)
<asynchronous suspension>
...
Committed:
https://github.com/dart-lang/sdk/commit/69d9c26416822807dd5f5deeecc5ba2b2a7a4035
==========

[aam, 2017-08-15 04:04:35]

Committed patchset #3 (id:40001) manually as
69d9c26416822807dd5f5deeecc5ba2b2a7a4035 (presubmit successful).