runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart - Issue 2995883002: Speedup Observatory elements first time rendering

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart

Issue 2995883002: Speedup Observatory elements first time rendering (Closed)

Patch Set: Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/observatory/lib/src/elements/helpers/rendering_queue.dart ('K') | « runtime/observatory/lib/src/elements/helpers/rendering_queue.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart

diff --git a/runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart b/runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart

index e3e81e07c22b06d3b4f8ff2af07fc9624ffbd9fd..fd0ce522376a07a4ef9f361d5c895dd56736e841 100644

--- a/runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart

+++ b/runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart

@@ -32,6 +32,7 @@ class RenderingScheduler<T extends Renderable> implements RenderingTask {

bool _dirty = false;

bool _renderingScheduled = false;

bool _notificationScheduled = false;

+ bool _firstTime = true;

/// Element managed by this scheduler.

final T element;

@@ -103,7 +104,8 @@ class RenderingScheduler<T extends Renderable> implements RenderingTask {

void scheduleRendering() {

if (_renderingScheduled) return;

if (!_enabled) return;

- queue.enqueue(this);

+ queue.enqueue(this, realtime: _firstTime);

+ _firstTime = false;

siva 2017/08/14 20:27:18 instead of a flag _firstTime which is toggled why

cbernaschina 2017/08/14 21:08:49 ditto

_renderingScheduled = true;

}