fix #30423, covariant parameter tearoff type should be Object

pkg/analyzer/lib/src/dart/element/element.dart

Index: pkg/analyzer/lib/src/dart/element/element.dart
diff --git a/pkg/analyzer/lib/src/dart/element/element.dart b/pkg/analyzer/lib/src/dart/element/element.dart
index 122de77747d5d01faa4d22802c298c7d936616dc..2379185a61a6ce8e5960b94b2c6268af82f45187 100644
--- a/pkg/analyzer/lib/src/dart/element/element.dart
+++ b/pkg/analyzer/lib/src/dart/element/element.dart
@@ -7225,6 +7225,10 @@ class MethodElementImpl extends ExecutableElementImpl implements MethodElement {
   MethodDeclaration computeNode() =>
       getNodeMatching((node) => node is MethodDeclaration);
 
+  // TODO(jmesserly): this implementation is completely wrong:
+  // It does not handle covariant parameters from a generic class.
+  // It drops type parameters from generic methods.
+  // Since this method was for DDC, it should be removed.
   @override
   FunctionType getReifiedType(DartType objectType) {

[Jennifer Messerly, 2017/08/12 00:10:49]

FYI: I want to remove this, because it's broken, and DDC is the only consumer.
However it does appear in the Element API. I doubt anyone uses it, though. Happy
to clean up in a follow up CL.

[Paul Berry, 2017/08/14 16:11:47]

Sounds good!  I suggest you mark it as @deprecated in this CL so that no one
starts using it in the meantime.

     // Check whether we have any covariant parameters.