fix #30423, covariant parameter tearoff type should be Object

fix #30423, covariant parameter tearoff type should be Object

some tests needed to be updated to reflect the informal spec semantics.

R=leafp@google.com, paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/d09868c02fa4f628b8a247cca5e8e6e83303b252

[Jennifer Messerly, 2017-08-12 00:07:47]

jmesserly@google.com changed reviewers:
+ paulberry@google.com

[Jennifer Messerly, 2017-08-12 00:08:29]

Description was changed from

==========
fix #30423, covariant parameter tearoff type should be Object

some tests needed to be updated to reflect the informal spec semantics.
==========

to

==========
fix #30423, covariant parameter tearoff type should be Object

some tests needed to be updated to reflect the informal spec semantics.
==========

[Jennifer Messerly, 2017-08-12 00:08:29]

jmesserly@google.com changed reviewers:
+ leafp@google.com

[Jennifer Messerly, 2017-08-12 00:10:49]

https://codereview.chromium.org/2995813002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/2995813002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:7233: FunctionType
getReifiedType(DartType objectType) {
FYI: I want to remove this, because it's broken, and DDC is the only consumer.
However it does appear in the Element API. I doubt anyone uses it, though. Happy
to clean up in a follow up CL.

https://codereview.chromium.org/2995813002/diff/1/tests/language_strong/funct...
File tests/language_strong/function_subtype2_test.dart (right):

https://codereview.chromium.org/2995813002/diff/1/tests/language_strong/funct...
tests/language_strong/function_subtype2_test.dart:17: get m1 => (T a, S b) {};
FYI: this test intent seems to be testing general function subtyping, not class
generics specifically, so I updated the test to preserve the old behavior.

[Paul Berry, 2017-08-14 16:11:47]

lgtm

https://codereview.chromium.org/2995813002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/2995813002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:7233: FunctionType
getReifiedType(DartType objectType) {
On 2017/08/12 00:10:49, Jennifer Messerly wrote:
> FYI: I want to remove this, because it's broken, and DDC is the only consumer.
> However it does appear in the Element API. I doubt anyone uses it, though.
Happy
> to clean up in a follow up CL.
> 

Sounds good!  I suggest you mark it as @deprecated in this CL so that no one
starts using it in the meantime.

[Leaf, 2017-08-15 21:06:20]

lgtm

[Jennifer Messerly, 2017-08-15 21:27:14]

Description was changed from

==========
fix #30423, covariant parameter tearoff type should be Object

some tests needed to be updated to reflect the informal spec semantics.
==========

to

==========
fix #30423, covariant parameter tearoff type should be Object

some tests needed to be updated to reflect the informal spec semantics.

R=leafp@google.com, paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d09868c02fa4f628b8a247cca5e8e6e83303b252
==========

[Jennifer Messerly, 2017-08-15 21:27:16]

Committed patchset #1 (id:1) manually as
d09868c02fa4f628b8a247cca5e8e6e83303b252 (presubmit successful).

[Leaf, 2017-08-16 00:02:17]

Oops.  I think this missed the language_2 tests that need updating.

[Jennifer Messerly, 2017-08-16 20:58:02]

On 2017/08/16 00:02:17, Leaf wrote:
> Oops.  I think this missed the language_2 tests that need updating.

oh gosh, do we know what happened? I ran a full test.py including language_2 ...
not sure if a test change landed in the meantime before I landed this CL or what