[vm] Implement more efficient CAS in simarm/simarm64 modes

runtime/vm/atomic.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_VM_ATOMIC_H_
 #define RUNTIME_VM_ATOMIC_H_
 
 #include "platform/globals.h"
 
 #include "vm/allocation.h"
-#include "vm/simulator.h"
 
 namespace dart {
 
 class AtomicOperations : public AllStatic {
  public:
   // Atomically fetch the value at p and increment the value at p.
   // Returns the original value at p.
   //
   // NOTE: Not to be used for any atomic operations involving memory locations

[rmacnak, 2017/08/11 23:44:46]

These comments about generated code can be removed now.

[alexmarkov, 2017/08/12 00:34:55]

Done.

   // that are accessed by generated code.
   static uintptr_t FetchAndIncrement(uintptr_t* p);
   static intptr_t FetchAndIncrement(intptr_t* p);
 
   // Atomically increment the value at p by 'value'.
   //
   // NOTE: Not to be used for any atomic operations involving memory locations
   // that are accessed by generated code.
   static void IncrementBy(intptr_t* p, intptr_t value);
   static void IncrementInt64By(int64_t* p, int64_t value);
@@ skipping 24 matching lines @@
   // Performs a load of a word from 'ptr', but without any guarantees about
   // memory order (i.e., no load barriers/fences).
   template <typename T>
   static T LoadRelaxed(T* ptr) {
     return *static_cast<volatile T*>(ptr);
   }
 };
 
 }  // namespace dart
 
-#if defined(USING_SIMULATOR) && !defined(TARGET_ARCH_DBC)
-#define USING_SIMULATOR_ATOMICS
-#endif
-
-#if defined(USING_SIMULATOR_ATOMICS)
-// We need to use the simulator to ensure that atomic operations are observed
-// both in C++ and in generated code if the simulator is active.
-#include "vm/atomic_simulator.h"
-#endif
-
 #if defined(HOST_OS_ANDROID)
 #include "vm/atomic_android.h"
 #elif defined(HOST_OS_FUCHSIA)
 #include "vm/atomic_fuchsia.h"
 #elif defined(HOST_OS_LINUX)
 #include "vm/atomic_linux.h"
 #elif defined(HOST_OS_MACOS)
 #include "vm/atomic_macos.h"
 #elif defined(HOST_OS_WINDOWS)
 #include "vm/atomic_win.h"
 #else
 #error Unknown target os.
 #endif
 
 #endif  // RUNTIME_VM_ATOMIC_H_