pkg/compiler/lib/src/deferred_load.dart - Issue 2995763003: Fix deferred bug: when type argument is never instantiated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/deferred_load.dart

Issue 2995763003: Fix deferred bug: when type argument is never instantiated (Closed)

Patch Set: makeit conditional to prevent infinite recursion Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/deferred_load.dart

diff --git a/pkg/compiler/lib/src/deferred_load.dart b/pkg/compiler/lib/src/deferred_load.dart

index 155c54dc39a247e03d71e6503ebdc1162db6b85c..fe9a4731edb41b6c4a3165dc2a876a4fb0ccfd1d 100644

--- a/pkg/compiler/lib/src/deferred_load.dart

+++ b/pkg/compiler/lib/src/deferred_load.dart

@@ -319,7 +319,9 @@ class DeferredLoadTask extends CompilerTask {

elements.add(type.element);

collectTypeDependencies(type.unaliased);

} else if (type is ResolutionInterfaceType) {

- elements.add(type.element);

+ if (elements.add(type.element)) {

+ collectTypeDependencies(type.element.supertype);

Siggi Cherem (dart-lang) 2017/08/11 21:34:52 I believe this may be including transitive deps, w

+ }

}

« no previous file with comments | « no previous file | tests/compiler/dart2js_extra/dart2js_extra.status » ('j') | no next file with comments »