Fix deferred bug: when type argument is never instantiated

Fix deferred bug: when type argument is never instantiated

R=johnniwinther@google.com, sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/f1e34ffd11f34b21ac6fcefc882cd5375b7dac43

[Siggi Cherem (dart-lang), 2017-08-11 19:25:40]

(fyi I'll upload a status file change shortly, since this will likely fail with
--use-kernel)

[Siggi Cherem (dart-lang), 2017-08-11 19:34:15]

https://codereview.chromium.org/2995763003/diff/20001/tests/compiler/dart2js_...
File tests/compiler/dart2js_extra/dart2js_extra.status (left):

https://codereview.chromium.org/2995763003/diff/20001/tests/compiler/dart2js_...
tests/compiler/dart2js_extra/dart2js_extra.status:193: 28749_test: Crash
these are unrelated, but because we are not running these in the bots, so they
got stale.

I'll run a larger update separately on the other suites. The only change that is
important for the bots is the one in the minified section at the bottom

[sra1, 2017-08-11 19:38:11]

lgtm

[Siggi Cherem (dart-lang), 2017-08-11 20:17:36]

Description was changed from

==========
Fix deferred bug: when type argument is never instantiated

R=sra@google.com,johnniwinther@google.com
==========

to

==========
Fix deferred bug: when type argument is never instantiated

R=johnniwinther@google.com, sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f1e34ffd11f34b21ac6fcefc882cd5375b7dac43
==========

[Siggi Cherem (dart-lang), 2017-08-11 20:17:37]

Committed patchset #3 (id:40001) manually as
f1e34ffd11f34b21ac6fcefc882cd5375b7dac43 (presubmit successful).

[Siggi Cherem (dart-lang), 2017-08-11 21:34:53]

https://codereview.chromium.org/2995763003/diff/40001/pkg/compiler/lib/src/de...
File pkg/compiler/lib/src/deferred_load.dart (right):

https://codereview.chromium.org/2995763003/diff/40001/pkg/compiler/lib/src/de...
pkg/compiler/lib/src/deferred_load.dart:323:
collectTypeDependencies(type.element.supertype);
I believe this may be including transitive deps, which is not the coal for the
_collectAllElementsAndConstantsResolvedFrom(...)

I propose this alternative fix instead:
https://codereview.chromium.org/3000843002/