Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 299573002: [Mac] Improve modal sheet positioning during window resizing. (Closed)

Created:
6 years, 7 months ago by Andre
Modified:
6 years, 7 months ago
Reviewers:
Avi (use Gerrit), Nico
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Improve modal sheet positioning during window resizing. Change sheet repositioning to be based on NSWindowDidResizeNotification, because it tracks window resizing much better than NSViewFrameDidChangeNotification. The modal sheet should now track the parent window's resizing much more smoothly. BUG=358627 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272421

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -13 lines) Patch
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.mm View 4 chunks +9 lines, -13 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller_unittest.mm View 1 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Andre
6 years, 7 months ago (2014-05-20 00:19:42 UTC) #1
Andre
Nico or Avi, can one of you review this change?
6 years, 7 months ago (2014-05-21 16:54:25 UTC) #2
Avi (use Gerrit)
lgtm
6 years, 7 months ago (2014-05-21 17:47:42 UTC) #3
Andre
The CQ bit was checked by andresantoso@chromium.org
6 years, 7 months ago (2014-05-21 17:48:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andresantoso@chromium.org/299573002/1
6 years, 7 months ago (2014-05-21 19:58:48 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 07:08:25 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 07:59:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/31387)
6 years, 7 months ago (2014-05-22 07:59:06 UTC) #8
Andre
The CQ bit was checked by andresantoso@chromium.org
6 years, 7 months ago (2014-05-22 19:27:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andresantoso@chromium.org/299573002/20001
6 years, 7 months ago (2014-05-22 19:28:40 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 23:17:14 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 07:06:52 UTC) #12
Message was sent while issue was closed.
Change committed as 272421

Powered by Google App Engine
This is Rietveld 408576698