Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: runtime/vm/kernel_isolate.cc

Issue 2995723002: - Convert all isolate flags to a bit field. (Closed)
Patch Set: Address build error. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/service_isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_isolate.cc
diff --git a/runtime/vm/kernel_isolate.cc b/runtime/vm/kernel_isolate.cc
index e66b58ba4eec33d913df28754005eb653c82f3cc..6020a27f8b7540576314d5519515afbaa7d6ad8c 100644
--- a/runtime/vm/kernel_isolate.cc
+++ b/runtime/vm/kernel_isolate.cc
@@ -30,10 +30,6 @@ namespace dart {
#define Z (T->zone())
DEFINE_FLAG(bool, trace_kernel, false, "Trace Kernel service requests.");
-DEFINE_FLAG(bool,
- use_dart_frontend,
- false,
- "Parse scripts with Dart-to-Kernel parser");
DEFINE_FLAG(bool,
show_kernel_isolate,
false,
@@ -50,14 +46,6 @@ class RunKernelTask : public ThreadPool::Task {
public:
virtual void Run() {
ASSERT(Isolate::Current() == NULL);
-
- if (!FLAG_use_dart_frontend) {
- ASSERT(FLAG_use_dart_frontend);
- // In release builds, make this a no-op. In debug builds, the
- // assert shows that this is not supposed to happen.
- return;
- }
-
#ifndef PRODUCT
TimelineDurationScope tds(Timeline::GetVMStream(), "KernelIsolateStartup");
#endif // !PRODUCT
@@ -199,9 +187,6 @@ class RunKernelTask : public ThreadPool::Task {
};
void KernelIsolate::Run() {
- if (!FLAG_use_dart_frontend) {
- return;
- }
// Grab the isolate create callback here to avoid race conditions with tests
// that change this after Dart_Initialize returns.
create_callback_ = Isolate::CreateCallback();
@@ -213,8 +198,7 @@ void KernelIsolate::InitCallback(Isolate* I) {
ASSERT(I == T->isolate());
ASSERT(I != NULL);
ASSERT(I->name() != NULL);
- if (!FLAG_use_dart_frontend ||
- (strstr(I->name(), DART_KERNEL_ISOLATE_NAME) == NULL)) {
+ if (strstr(I->name(), DART_KERNEL_ISOLATE_NAME) == NULL) {
// Not kernel isolate.
return;
}
@@ -257,9 +241,6 @@ void KernelIsolate::FinishedInitializing() {
}
Dart_Port KernelIsolate::WaitForKernelPort() {
- if (!FLAG_use_dart_frontend) {
- return ILLEGAL_PORT;
- }
MonitorLocker ml(monitor_);
while (initializing_ && (kernel_port_ == ILLEGAL_PORT)) {
ml.Wait();
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/service_isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698