fix list_unmodifiable_test

fix list_unmodifiable_test

This test had some runtime soundness errors. I've added some type annotations to make those easier to catch, and also made the test a bit more rigorous about whether an error is expected.

R=bkonyi@google.com

Committed: https://github.com/dart-lang/sdk/commit/04f61db8a85a1fdd88fd0e1b0fb908ceb335867f

[Jennifer Messerly, 2017-08-09 18:47:24]

jmesserly@google.com changed reviewers:
+ bkonyi@google.com

[Jennifer Messerly, 2017-08-09 18:47:25]

https://codereview.chromium.org/2995703002/diff/1/tests/corelib_2/list_unmodi...
File tests/corelib_2/list_unmodifiable_test.dart (left):

https://codereview.chromium.org/2995703002/diff/1/tests/corelib_2/list_unmodi...
tests/corelib_2/list_unmodifiable_test.dart:174: success("elementAt", (l) =>
l.elementAt[1]);
note the square brackets ... oops!

[bkonyi, 2017-08-09 19:28:39]

LGTM after fixing the [..] you mentioned :)

[Jennifer Messerly, 2017-08-09 20:16:51]

On 2017/08/09 19:28:39, bkonyi wrote:
> LGTM after fixing the [..] you mentioned :)

oh, that was in the old code! maybe I'm misreading your comment? Is there
something I should fix in the new code before landing it?

[Jennifer Messerly, 2017-08-11 20:19:26]

Description was changed from

==========
fix list_unmodifiable_test

This test had some runtime soundness errors. I've added some type annotations to
make those easier to catch, and also made the test a bit more rigorous about
whether an error is expected.
==========

to

==========
fix list_unmodifiable_test

This test had some runtime soundness errors. I've added some type annotations to
make those easier to catch, and also made the test a bit more rigorous about
whether an error is expected.

R=bkonyi@google.com

Committed:
https://github.com/dart-lang/sdk/commit/04f61db8a85a1fdd88fd0e1b0fb908ceb335867f
==========

[Jennifer Messerly, 2017-08-11 20:19:27]

Committed patchset #1 (id:1) manually as
04f61db8a85a1fdd88fd0e1b0fb908ceb335867f (presubmit successful).