Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issue 2995693002: Puts TLABs back into the build and fixes assert failure. (Closed)

Created:
3 years, 4 months ago by danunez
Modified:
3 years, 4 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Puts TLABs back into the build and fixes assert failure. This CL reintroduces the following commits (by reverting 91662ce57) 7568e1f18 : Reintroduces TLABs with fix for bug in 8b6fcf50e85d 91470e721 : Scavenger::UsedInWords() is now accurate to TLABs 479db734e : Fixes IO regression casued by 7568e1f18 R=asiva@google.com, rmacnak@google.com Furthermore, this CL fixes a bug where unscheduling the mutator thread and then walking the heap results in the assertion in Scavenger::MakeNewSpaceIterable() fail due to a null heap. Committed: https://github.com/dart-lang/sdk/commit/4c471b3f2733529d1b263596550b9bae3b38d88c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -54 lines) Patch
M runtime/vm/heap.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/heap.cc View 2 chunks +58 lines, -9 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M runtime/vm/scavenger.h View 7 chunks +26 lines, -7 lines 0 comments Download
M runtime/vm/scavenger.cc View 8 chunks +32 lines, -26 lines 0 comments Download
M runtime/vm/thread.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danunez
3 years, 4 months ago (2017-08-09 19:27:05 UTC) #1
rmacnak
lgtm
3 years, 4 months ago (2017-08-09 20:54:22 UTC) #2
danunez
3 years, 4 months ago (2017-08-09 20:55:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4c471b3f2733529d1b263596550b9bae3b38d88c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698