Initial experimental Kythe Dart Analysis Server protocol

Initial experimental Kythe Dart Analysis Server protocol

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/8a426f3d6774f49beb3dcfb35aaaa0e645c38ff5

[jwren, 2017-08-09 17:15:18]

jwren@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2017-08-09 17:44:11]

https://codereview.chromium.org/2995683002/diff/1/pkg/analysis_server/tool/sp...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/2995683002/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/spec_input.html:3021: This object has matches the
format and documentation of the Entry object documented in the
"has matches" --> "matches"

https://codereview.chromium.org/2995683002/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/spec_input.html:3061: This object has matches the
format and documentation of the Vector-Name object documented in
"has matches" --> "matches"

https://codereview.chromium.org/2995683002/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/spec_input.html:3075: The corpus of source code
this VName belongs to. Loosely, a corpus is a collection of
"VName" --> "KytheVName" to match the name of the type in the spec.

https://codereview.chromium.org/2995683002/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/spec_input.html:3093: <field name="language">
Do we need this, or should it always be set to "dart" by the wrapper?

[jwren, 2017-08-09 19:34:48]

https://codereview.chromium.org/2995683002/diff/1/pkg/analysis_server/tool/sp...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/2995683002/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/spec_input.html:3021: This object has matches the
format and documentation of the Entry object documented in the
On 2017/08/09 17:44:11, Brian Wilkerson wrote:
> "has matches" --> "matches"

Done.

https://codereview.chromium.org/2995683002/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/spec_input.html:3061: This object has matches the
format and documentation of the Vector-Name object documented in
On 2017/08/09 17:44:11, Brian Wilkerson wrote:
> "has matches" --> "matches"

Done.

https://codereview.chromium.org/2995683002/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/spec_input.html:3075: The corpus of source code
this VName belongs to. Loosely, a corpus is a collection of
On 2017/08/09 17:44:11, Brian Wilkerson wrote:
> "VName" --> "KytheVName" to match the name of the type in the spec.

Done.

https://codereview.chromium.org/2995683002/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/spec_input.html:3093: <field name="language">
On 2017/08/09 17:44:11, Brian Wilkerson wrote:
> Do we need this, or should it always be set to "dart" by the wrapper?

With future work, such as for angular source, we will have "html" support in the
future.

[Brian Wilkerson, 2017-08-09 19:41:09]

lgtm

[jwren, 2017-08-09 19:45:04]

Description was changed from

==========
Initial experimental Kythe Dart Analysis Server protocol
==========

to

==========
Initial experimental Kythe Dart Analysis Server protocol

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8a426f3d6774f49beb3dcfb35aaaa0e645c38ff5
==========

[jwren, 2017-08-09 19:45:06]

Committed patchset #3 (id:40001) manually as
8a426f3d6774f49beb3dcfb35aaaa0e645c38ff5 (presubmit successful).