Support jsinterop/world_test from .dill

Support jsinterop/world_test from .dill

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/fd81ba456925b1bb825f4bee2f13b4bbcdcf4f97

[Johnni Winther, 2017-08-09 09:39:08]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-08-09 16:11:15]

lgtm

https://codereview.chromium.org/2995643002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map.dart (right):

https://codereview.chromium.org/2995643002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map.dart:145: /// Computes the native
behavior for calling [procedure].
should we rename [procedure] to [member]? Maybe indicate which kind of members
are allowed?

https://codereview.chromium.org/2995643002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map_mixins.dart (right):

https://codereview.chromium.org/2995643002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_mixins.dart:405: /// Computes the native
behavior for calling [procedure].
procedure => member

https://codereview.chromium.org/2995643002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/native_basic_data.dart (right):

https://codereview.chromium.org/2995643002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/native_basic_data.dart:158:
checkFunctionParameters(constructor);
isn't the constructor included in `forEachClassMember`? If so, can we delete
this `else` branch ?

[Johnni Winther, 2017-08-10 08:02:08]

https://codereview.chromium.org/2995643002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map.dart (right):

https://codereview.chromium.org/2995643002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map.dart:145: /// Computes the native
behavior for calling [procedure].
On 2017/08/09 16:11:14, Siggi Cherem (dart-lang) wrote:
> should we rename [procedure] to [member]? Maybe indicate which kind of members
> are allowed?

Done.

https://codereview.chromium.org/2995643002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map_mixins.dart (right):

https://codereview.chromium.org/2995643002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_mixins.dart:405: /// Computes the native
behavior for calling [procedure].
On 2017/08/09 16:11:15, Siggi Cherem (dart-lang) wrote:
> procedure => member

Done.

https://codereview.chromium.org/2995643002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/native_basic_data.dart (right):

https://codereview.chromium.org/2995643002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/native_basic_data.dart:158:
checkFunctionParameters(constructor);
On 2017/08/09 16:11:15, Siggi Cherem (dart-lang) wrote:
> isn't the constructor included in `forEachClassMember`? If so, can we delete
> this `else` branch ?

It isn't.

[Johnni Winther, 2017-08-10 08:13:29]

Description was changed from

==========
Support jsinterop/world_test from .dill
==========

to

==========
Support jsinterop/world_test from .dill

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fd81ba456925b1bb825f4bee2f13b4bbcdcf4f97
==========

[Johnni Winther, 2017-08-10 08:13:30]

Committed patchset #2 (id:20001) manually as
fd81ba456925b1bb825f4bee2f13b4bbcdcf4f97 (presubmit successful).