Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2995553002: Implement type inference for asserts in constructor initializers. (Closed)

Created:
3 years, 4 months ago by Paul Berry
Modified:
3 years, 4 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement type inference for asserts in constructor initializers. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/1b9ba53fb6c56719a8242db2fda6369b5d9429ed

Patch Set 1 #

Messages

Total messages: 5 (2 generated)
Paul Berry
I only need a review from one of you.
3 years, 4 months ago (2017-08-04 23:36:04 UTC) #2
scheglov
LGTM
3 years, 4 months ago (2017-08-04 23:38:00 UTC) #3
Paul Berry
3 years, 4 months ago (2017-08-05 00:55:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b9ba53fb6c56719a8242db2fda6369b5d9429ed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698