runtime/vm/service.cc - Issue 2995543004: [vm, gc] Require a safepoint for heap iteration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/service.cc

Issue 2995543004: [vm, gc] Require a safepoint for heap iteration. (Closed)

Patch Set: explicit-thread Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/service.cc

diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc

index be4bd31e197364af831d05df3b095d19ff40f326..f1614693021c5bbd79e46725777524b60c56b634 100644

--- a/runtime/vm/service.cc

+++ b/runtime/vm/service.cc

@@ -2404,7 +2404,7 @@ static bool GetInstances(Thread* thread, JSONStream* js) {

Array& storage = Array::Handle(Array::New(limit));

GetInstancesVisitor visitor(cls, storage);

ObjectGraph graph(thread);

- HeapIterationScope iteration_scope(true);

+ HeapIterationScope iteration_scope(Thread::Current(), true);

graph.IterateObjects(&visitor);

intptr_t count = visitor.count();

JSONObject jsobj(js);

« no previous file with comments | « runtime/vm/scavenger.cc ('k') | runtime/vm/stack_frame_test.cc » ('j') | no next file with comments »