Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: runtime/vm/object_graph_test.cc

Issue 2995543004: [vm, gc] Require a safepoint for heap iteration. (Closed)
Patch Set: explicit-thread Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object_graph.cc ('k') | runtime/vm/object_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_graph_test.cc
diff --git a/runtime/vm/object_graph_test.cc b/runtime/vm/object_graph_test.cc
index fb2329089956e7f544d044ac06dae58305bb94a2..72cffefb856f19e5aecefc879ed8e3c486cb7d35 100644
--- a/runtime/vm/object_graph_test.cc
+++ b/runtime/vm/object_graph_test.cc
@@ -58,7 +58,7 @@ ISOLATE_UNIT_TEST_CASE(ObjectGraph) {
intptr_t d_size = d.raw()->Size();
{
// No more allocation; raw pointers ahead.
- NoSafepointScope no_safepoint_scope;
+ SafepointOperationScope safepoint(thread);
RawObject* b_raw = b.raw();
// Clear handles to cut unintended retained paths.
b = Array::null();
@@ -66,7 +66,7 @@ ISOLATE_UNIT_TEST_CASE(ObjectGraph) {
d = Array::null();
ObjectGraph graph(thread);
{
- HeapIterationScope iteration_scope(true);
+ HeapIterationScope iteration_scope(thread, true);
{
// Compare count and size when 'b' is/isn't skipped.
CounterVisitor with(Object::null(), Object::null());
« no previous file with comments | « runtime/vm/object_graph.cc ('k') | runtime/vm/object_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698