runtime/vm/become.cc - Issue 2995543004: [vm, gc] Require a safepoint for heap iteration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/become.cc

Issue 2995543004: [vm, gc] Require a safepoint for heap iteration. (Closed)

Patch Set: explicit-thread Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/become.cc

diff --git a/runtime/vm/become.cc b/runtime/vm/become.cc

index 207a771d756430b60080880c20948d4587245a28..e3982b86fb0a4580185f0ed30ed6fc426858aed0 100644

--- a/runtime/vm/become.cc

+++ b/runtime/vm/become.cc

@@ -215,7 +215,7 @@ void Become::ElementsForwardIdentity(const Array& before, const Array& after) {

Heap* heap = isolate->heap();

TIMELINE_FUNCTION_GC_DURATION(thread, "Become::ElementsForwardIdentity");

- HeapIterationScope his;

+ HeapIterationScope his(thread);

// Setup forwarding pointers.

ASSERT(before.Length() == after.Length());

« no previous file with comments | « no previous file | runtime/vm/benchmark_test.cc » ('j') | no next file with comments »