[vm, gc] Require a safepoint for heap iteration.

runtime/vm/heap.h

Index: runtime/vm/heap.h
diff --git a/runtime/vm/heap.h b/runtime/vm/heap.h
index 2acc2b188b602ca2a5f7e4760ff937d4beae3e5d..cb3f5852f6fce748131896ba0c321dbb8260b534 100644
--- a/runtime/vm/heap.h
+++ b/runtime/vm/heap.h
@@ -93,11 +93,6 @@ class Heap {
   bool CodeContains(uword addr) const;
   bool DataContains(uword addr) const;
 
-  void IterateObjects(ObjectVisitor* visitor) const;
-  void IterateOldObjects(ObjectVisitor* visitor) const;
-  void IterateOldObjectsNoImagePages(ObjectVisitor* visitor) const;
-  void IterateObjectPointers(ObjectVisitor* visitor) const;
-
   // Find an object by visiting all pointers in the specified heap space,
   // the 'visitor' is used to determine if an object is found or not.
   // The 'visitor' function should be set up to return true if the
@@ -360,12 +355,12 @@ class Heap {
 
   friend class Become;       // VisitObjectPointers
   friend class Precompiler;  // VisitObjects
-  friend class ObjectGraph;  // VisitObjects
   friend class Unmarker;     // VisitObjects
   friend class ServiceEvent;
   friend class PageSpace;             // VerifyGC
   friend class IsolateReloadContext;  // VisitObjects
   friend class ClassFinalizer;        // VisitObjects
+  friend class HeapIterationScope;    // VisitObjects
 
   DISALLOW_COPY_AND_ASSIGN(Heap);
 };
@@ -375,8 +370,20 @@ class HeapIterationScope : public StackResource {
   explicit HeapIterationScope(bool writable = false);

[siva, 2017/08/07 23:28:38]

Why not add the 'Thread* thread' parameter here.

[rmacnak, 2017/08/08 00:29:41]

Done.

   ~HeapIterationScope();
 
+  void IterateObjects(ObjectVisitor* visitor) const;
+  void IterateObjectsNoImagePages(ObjectVisitor* visitor) const;
+  void IterateOldObjects(ObjectVisitor* visitor) const;
+  void IterateOldObjectsNoImagePages(ObjectVisitor* visitor) const;
+
+  void IterateVMIsolateObjects(ObjectVisitor* visitor) const;
+
+  void IterateObjectPointers(ObjectPointerVisitor* visitor,
+                             bool validate_frames);
+  void IterateStackPointers(ObjectPointerVisitor* visitor,
+                            bool validate_frames);
+
  private:
-  NoSafepointScope no_safepoint_scope_;
+  Heap* heap_;
   PageSpace* old_space_;
   bool writable_;