Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2995453002: Fix bots from block 8 (Closed)

Created:
3 years, 4 months ago by jcollins
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom, siva
CC:
reviews_dartlang.org, dart2now-team_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add dartk to MissingCompileTimeError for const_type tests #

Patch Set 3 : Revert the script change -- need to build the precompiler too and don't want to delay bot fixing #

Patch Set 4 : drop comma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/corelib_2/corelib_2.status View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
jcollins
Fixes the bots and makes a simple change to the test runner script so that ...
3 years, 4 months ago (2017-08-03 16:34:58 UTC) #2
Bob Nystrom
lgtm
3 years, 4 months ago (2017-08-03 16:55:27 UTC) #3
jcollins
3 years, 4 months ago (2017-08-03 17:10:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
8210a8cd3d7eb023266f67d6207a7624c5facf09 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698