Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: tools/patch_sdk.dart

Issue 2995423002: Allow the VM to read Kernel files with external libraries (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/kernel_reader.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/patch_sdk.dart
diff --git a/tools/patch_sdk.dart b/tools/patch_sdk.dart
index 97e2e12c8c95400bf74a578d9094bbbba212099f..f4ada816497bf9e44d1dc0e52f009ca530ea7956 100644
--- a/tools/patch_sdk.dart
+++ b/tools/patch_sdk.dart
@@ -164,16 +164,10 @@ Future _main(List<String> argv) async {
Uri.parse('dart:$vmserviceName'),
new CompilerOptions()
..setExitCodeOnProblem = true
- // TODO(sigmund): investigate. This should be outline, but it breaks
- // vm-debug tests. Issue #30111
- ..sdkSummary = platform
+ ..sdkSummary = outline
..librariesSpecificationUri = vmserviceJsonUri
..packagesFileUri = packages);
Uri vmserviceUri = outDirUri.resolve('$vmserviceName.dill');
- // TODO(sigmund): remove. This is a workaround because in the VM
- // doesn't support loading vmservice if it contains external libraries
- // (there is an assertion that only fails in debug builds). Issue #30111
- program.libraries.forEach((l) => l.isExternal = false);
await writeProgramToFile(program, vmserviceUri);
}
« no previous file with comments | « runtime/vm/kernel_reader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698