Issue 2995423002: Allow the VM to read Kernel files with external libraries

Issue 2995423002: Allow the VM to read Kernel files with external libraries (Closed)

Created:
3 years, 4 months ago by Kevin Millikin (Google)

Modified:
3 years, 4 months ago

Reviewers:
jensj

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Allow the VM to read Kernel files with external libraries The meaning of a Kernel file with an external library is that the library is one that is already known to be loaded in the VM. Fixes issue #30111. BUG=https://github.com/dart-lang/sdk/issues/30111 R=jensj@google.com Committed: https://github.com/dart-lang/sdk/commit/2f4919852095ee3287d35e138184c11e29b3ce8d

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -29 lines)			Patch
M	runtime/vm/kernel_binary.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/kernel_binary_flowgraph.h	View	7 chunks	+12 lines, -5 lines	0 comments	Download
M	runtime/vm/kernel_binary_flowgraph.cc	View	7 chunks	+10 lines, -15 lines	0 comments	Download
M	runtime/vm/kernel_reader.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/kernel_reader.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/patch_sdk.dart	View	1 chunk	+1 line, -7 lines	0 comments	Download

Total messages: 5 (2 generated)

jensj

I've tried adding the comments "// read <field>." consistently to make it easier to see ...

3 years, 4 months ago (2017-08-22 13:08:47 UTC) #3

Kevin Millikin (Google)

3 years, 4 months ago (2017-08-22 14:05:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2f4919852095ee3287d35e138184c11e29b3ce8d (presubmit successful).