Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/compiler/lib/src/ssa/builder_kernel.dart

Issue 2995353002: Test the CapturedScope for local functions (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/compiler/lib/src/js_model/closure.dart ('K') | « pkg/compiler/lib/src/ssa/builder.dart ('k') | pkg/compiler/lib/src/ssa/locals_handler.dart » ('j') | tests/compiler/dart2js/closure/closure_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/builder_kernel.dart
diff --git a/pkg/compiler/lib/src/ssa/builder_kernel.dart b/pkg/compiler/lib/src/ssa/builder_kernel.dart
index 75547da496dc779ee7908395b4493269eeebee09..c03ba93aa5c47d702ecce32e6e5ee825011c52ff 100644
--- a/pkg/compiler/lib/src/ssa/builder_kernel.dart
+++ b/pkg/compiler/lib/src/ssa/builder_kernel.dart
@@ -401,8 +401,8 @@ class KernelSsaGraphBuilder extends ir.Visitor
// box to the constructor.
CapturedScope scopeData =
closureDataLookup.getCapturedScope(constructorElement);
- if (scopeData.requiresContextBox) {
- bodyCallInputs.add(localsHandler.readLocal(scopeData.context));
+ if (scopeData.hasBox) {
+ bodyCallInputs.add(localsHandler.readLocal(scopeData.box));
}
// Pass type arguments.
« pkg/compiler/lib/src/js_model/closure.dart ('K') | « pkg/compiler/lib/src/ssa/builder.dart ('k') | pkg/compiler/lib/src/ssa/locals_handler.dart » ('j') | tests/compiler/dart2js/closure/closure_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698